Skip to content

docs: generate TypeDoc without missing-type warnings - #153

Draft
mcansh wants to merge 1 commit into
logan/hibpfrom
logan/typedoc
Draft

mcansh wants to merge 1 commit into
logan/hibpfrom
logan/typedoc

Conversation

@mcansh

@mcansh mcansh commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Expand helper types referenced in public API signatures using TypeDoc @inline annotations. Include the response matcher JSON value type in the generated signatures. Add schema declarations to package TypeDoc configs so editors validate their options.

public signature → expanded helper type → usable API documentation

These changes only alter comments and documentation configuration.

Evidence

  • Before: documentation generation reported eight missing-type warnings.
    After: typedoc --treatWarningsAsErrors generates HTML and JSON for all five packages with zero errors and zero warnings.

  • Inspected generated API JSON to confirm helper type references were expanded.

  • git diff --check, warning-free TypeDoc generation, and GitHub build/test and HIBP runtime workflows pass on the final head.

  • Remaining external failure: Cloudflare Workers Builds is still failing. Its build-log API returns 403 with the existing local credential, so the deployment cause is unverified.

Merge Danger

Door: two-way

Revert this layer to restore the prior generated documentation shape.

Blast Radius: documentation

Inlining expands repeated type definitions and can increase generated documentation size. No runtime code or exports change in this layer.

Stack: #150 → #151 → #152 → #153. Merge from the bottom after checks pass.

Stack created with GitHub Stacks CLI

@mcansh
mcansh added this pull request to stack #154 October 6, 2026 20:17
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7103786

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh changed the title docs: inline API helper types for warning-free TypeDoc docs: generate TypeDoc without missing-type warnings Oct 6, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
packages 7103786 Oct 06 2026, 09:03 PM

@mcansh
mcansh force-pushed the logan/typedoc branch 2 times, most recently from 9e78183 to dc28a27 Compare October 6, 2026 20:27
@mcansh
mcansh marked this pull request as ready for review October 6, 2026 20:28
Copilot AI balanced review requested due to automatic review settings October 6, 2026 20:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T21:05:39.855699Z 7103786 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation-only changes consistently address missing helper-type references without affecting runtime behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Improves TypeDoc output by expanding internal helper types in public signatures and enabling configuration validation.

Changes:

  • Adds @inline annotations to documentation-only helper types.
  • Adds TypeDoc schema declarations to package configurations.
File Description
packages/​vitest-response-matchers/​typedoc.json Adds TypeDoc schema validation.
packages/​url/​typedoc.json Adds TypeDoc schema validation.
packages/​http-helmet/​typedoc.json Adds TypeDoc schema validation.
packages/​http-helmet/​src/​utils.ts Inlines source-related helper types.
packages/​http-helmet/​src/​rules/​permissions.ts Inlines permission key types.
packages/​http-helmet/​src/​rules/​content-security-policy.ts Inlines CSP helper types.
packages/​http-helmet/​src/​react.tsx Inlines provider props.
packages/​http-helmet/​src/​helmet.ts Inlines secure-header base properties.
packages/​create-temporary-files/​typedoc.json Adds TypeDoc schema validation.
packages/​create-temporary-files/​src/​lib.ts Inlines temporary-file parameters.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This review covers PR #153: "docs: generate TypeDoc without missing-type warnings". The changes add @inline annotations to TypeDoc so helper types referenced in public API signatures are expanded inline, and add $schema to package typedoc.json configs. No runtime code, exports, or public API shapes are changed.

  • TypeDoc inline annotations (8 files in http-helmet/create-temporary-files): added /** @inline */ to internal helper types that appear in public signatures so TypeDoc expands them rather than emitting missing-type warnings.
  • typedoc.json schema (5 packages): added $schema: "https://typedoc.org/schema.json" to improve editor validation; configs otherwise unchanged.

Pullfrog  | View workflow run | Using big-pickle (free) | 𝕏

@mcansh
mcansh force-pushed the logan/typedoc branch 2 times, most recently from 9764d2b to 259ae34 Compare October 6, 2026 21:01
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.12%. Comparing base (bc040b4) to head (7103786).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           logan/hibp     #153   +/-   ##
===========================================
  Coverage       93.12%   93.12%           
===========================================
  Files              23       23           
  Lines             378      378           
  Branches           97       97           
===========================================
  Hits              352      352           
  Misses             26       26           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcansh mcansh self-assigned this Oct 6, 2026
@mcansh
mcansh marked this pull request as draft October 6, 2026 21:08
@mcansh
mcansh removed this pull request from stack #154 October 7, 2026 00:02
@mcansh
mcansh added this pull request to stack #156 October 7, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants