Skip to content

Fix search not displaying when no tags exist #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcintyre94 merged 1 commit into from
Jan 21, 2026
Merged

Fix search not displaying when no tags exist #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions entrypoints/sidepanel/components/TagFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,29 +76,31 @@ export default function TagFilters({ tags, filtersEnabled, searchQuery, fetcher
};
}, []);

if (tags.length === 0) return null;
const hasTags = tags.length > 0;

return (
<Box>
<fetcher.Form action="/filtered-accounts">
<Stack gap="md" align="flex-start">
<Group gap="sm" align="center" wrap="nowrap" style={{ width: '100%' }}>
<Switch
withThumbIndicator={false}
labelPosition="left"
label="Enable tag filtering"
size="md"
name='enableFilters'
id='enableFilters'
value='enabled'
defaultChecked={filtersEnabled}
color="blue.5"
styles={{
label: { whiteSpace: 'pre-wrap', maxWidth: '120px' },
body: { alignItems: 'center' },
}}
onChange={handleNonSearchChange}
/>
{hasTags && (
<Switch
withThumbIndicator={false}
labelPosition="left"
label="Enable tag filtering"
size="md"
name='enableFilters'
id='enableFilters'
value='enabled'
defaultChecked={filtersEnabled}
color="blue.5"
styles={{
label: { whiteSpace: 'pre-wrap', maxWidth: '120px' },
body: { alignItems: 'center' },
}}
onChange={handleNonSearchChange}
/>
)}

<TextInput
type='search'
Expand All @@ -117,7 +119,7 @@ export default function TagFilters({ tags, filtersEnabled, searchQuery, fetcher
}}
/>
</Group>
{filtersEnabled ?
{filtersEnabled && hasTags && (
<Group gap="xs">
{tags.map(tag =>
<TagCheckbox
Expand All @@ -130,8 +132,7 @@ export default function TagFilters({ tags, filtersEnabled, searchQuery, fetcher
>{tag.tagName}</TagCheckbox>
)}
</Group>
: null
}
)}
</Stack>
</fetcher.Form>
</Box>
Expand Down