Repository navigation
Mark the Device Posture API as unsupported in WebView Android - #31033
Merged
Merged
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebView Android doesn't expose the Device Posture API, so this sets
webview_androidtofalseforapi.Navigator.devicePostureandapi.DevicePosture(and itstypeandchange_event) instead of mirroring Chrome.Test results and supporting details
Chromium turns the API off for WebView in
aw_field_trials.cc:That line landed in May 2024 (CL 5548161, crbug.com/335314107), before Chrome 132 shipped the API, so WebView never had it. This matches the test in #30973:
'devicePosture' in navigatorisfalsein WebView 155 andtruein Chrome on the same phone.I left the
device-posturemedia feature as it is, since #30973 shows it working in WebView.The same Chromium change also turns off
kViewportSegments, soapi.Viewport.segmentsmay have the same problem in WebView. I haven't tested that one.Related issues
Fixes #30973