Draft
Conversation
* added new separation constraint * changes * new changes * found the issue and meed to be fixed * fixing * fixed output mode * Fixed the unit vectors * adding slices * adding slices corrections * updated the addslices option * Setting default options * merge fix * mulit US mesh for mphys wrapper * Several fixes and adding test function * Test for separation * multi US mesh option in mphys * doc update and slight tol adjustment for new test * test update * update aoa in ap * update in ap * jason file update * test function fixes * flake8 and black * fixed the test option for new changes * minnor fix * commiting fprettify changes * fixing flake errors * minor Fixes and tests function * tapenade files * style fixes and tolerance update * style fixes * fprettify fixes * option * complex test * changing variable names * fprettify cahnge * error fix * tolerance update * tolerance update * removing multi US mesh * removing separation formulation * tapenade changes * minor fixes --------- Co-authored-by: Galen <68572680+gang525@users.noreply.github.com>
anilyil
requested review from
eirikurj and
lamkina
and removed request for
a team and
eirikurj
Collaborator
|
Was there anything more that needed to happen here before merging into the |
|
@gawng I think this effort is currently stalled and I don't think there's a timeline on anyone continuing this effort at the moment. I think it's best to leave this as a draft for now. |
Collaborator
|
Ok, I'm removing this from the 2024 workshop sheet EDIT: I am working on the user interface side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds the first interface that lets users add "active" slices and query the current slice data in ADflow through memory.
addActiveSlicemethod in pyADflow is used to define the active slices; one at a time for now.getActiveSliceDatamethod in pyADflow returns all of the active slice data in a dictionary.Ultimately, we will want to process this data in the dict by directly passing it to the airfoil classes, and we can just bookkeep the airfoil class instances in pyADflow.
I am attaching a script to run the example code. This is a simplified script from our airfoil tutorial, with the relevant naca0012 mesh.
active_slice_test_files.zip