fix: catalog multi-channel support and upgrade metadata#172
Conversation
|
Skipping CI for Draft Pull Request. |
|
Warning Review limit reached
Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
razo7
left a comment
There was a problem hiding this comment.
Thanks for the fix after medik8s/node-healthcheck-operator#311 discussion.
Please care to include https://redhat.atlassian.net/browse/RHWA-351 or the child issue in the PR description for reference
a629b72 to
15f06db
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 47-48: The DEFAULT_CHANNEL assignment is unconditional, which
prevents environment overrides and makes bundle always see a defined value.
Update the Makefile definition near DEFAULT_CHANNEL so it uses conditional
assignment instead of a hard assignment, preserving the default while still
allowing callers and the bundle target to override it via DEFAULT_CHANNEL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d45a1e03-2cb5-470b-9858-82665aec748e
📒 Files selected for processing (2)
.gitignoreMakefile
razo7
left a comment
There was a problem hiding this comment.
Thanks for addressing the changes and I left one small NIT
Feel free to unhold if you disagree or want to fix it later
/hold
15f06db to
01f4aa2
Compare
Use DEFAULT_CHANNEL in opm init, add channel iteration for multi-channel support, and include upgrade metadata (replaces, skipRange) in channel entries. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
01f4aa2 to
65020cd
Compare
razo7
left a comment
There was a problem hiding this comment.
One more small NIT since we are using DEFAULT_CHANNEL in the PR
Prevents build errors by ensuring the default channel is always included in the channel list. Co-authored-by: Claude Sonnet 4.5
65020cd to
e3a51bc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test 4.23-ci-bundle-my-bundle |
|
/unhold |
|
/retest |
|
@clobrano: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
Why we need this PR
The currently File-based catalog does not handle
multi-channelcorrectly.Changes made
Which issue(s) this PR fixes
Related to RHWA-351
Test plan
Summary by CodeRabbit
New Features
Bug Fixes
Chores