Do not try to render cached data if none is there#623
Merged
Conversation
vasconsaurus
changed the title
When we get a timeout, and 'must_render' was set to false, we called render_as_json, but data was nil. Which cause our NoMethodError. It still worked, because this error was caught and dealt with eventually. Still, if we get a timeout we always must render, so we can hardcode true, and avoid the error we saw in Sentry.
vasconsaurus
force-pushed
the
bug/nomethoderror-process_and_return_json
branch
from
26f4f63 to
9b191d8
Compare
vasconsaurus
changed the title
vasconsaurus
changed the title
melsawy
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
We keep getting a
NoMethodErrorfromrender_as_jsonbecausedatawasnil.Since the Pender Audit had been pretty stable and under control, I took
some time to look into this. Fewer errors mean less work in the audit hour.
Sentry Issue: PENDER-1AG
Cause
When we got a timeout, and 'must_render' was set to
false, we calledrender_as_json.Because of the timeout, data was
nil, which caused ourNoMethodError.It still "worked", meaning a media was created because this error was caught and dealt with eventually.
Fix
If we get a timeout we always must render so we can hardcode
true.How has this been tested?
I added a new test
should not try to render cached data if none is there.rails test test/controllers/medias_controller_test.rb:169