-
Notifications
You must be signed in to change notification settings - Fork 269
Add guide on Semantic search with gemini #3405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
guides/embedders/gemini.mdx
Outdated
| } | ||
| "url": "https://generativelanguage.googleapis.com/v1beta/models/gemini-embedding-001:batchEmbedContents", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing comma after the headers object in the Gemini embedder guide's JSON configuration, leading to invalid JSON.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The Gemini embedder guide contains a critical JSON syntax error. Specifically, there is a missing comma after the closing brace } of the "headers" object, before the "url" key. This invalidates the JSON structure, causing JSON parsers to reject the configuration. Users attempting to apply this configuration via the Meilisearch API will encounter parsing failures, preventing them from setting up Gemini embeddings and enabling the semantic search feature described in the guide.
💡 Suggested Fix
Add a comma , after the closing brace } of the "headers" object on line 35 in guides/embedders/gemini.mdx, before the "url" key, to correct the JSON syntax.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: guides/embedders/gemini.mdx#L35-L36
Potential issue: The Gemini embedder guide contains a critical JSON syntax error.
Specifically, there is a missing comma after the closing brace `}` of the `"headers"`
object, before the `"url"` key. This invalidates the JSON structure, causing JSON
parsers to reject the configuration. Users attempting to apply this configuration via
the Meilisearch API will encounter parsing failures, preventing them from setting up
Gemini embeddings and enabling the semantic search feature described in the guide.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2839307
| ## Introduction | ||
|
|
||
| This guide will walk you through the process of setting up Meilisearch with Gemini embeddings to enable semantic search capabilities. By leveraging Meilisearch's AI features and Gemini's embedding API, you can enhance your search experience and retrieve more relevant results. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can skip the intro. The description is already printed on the page.
| ## Introduction | |
| This guide will walk you through the process of setting up Meilisearch with Gemini embeddings to enable semantic search capabilities. By leveraging Meilisearch's AI features and Gemini's embedding API, you can enhance your search experience and retrieve more relevant results. |
| To follow this guide, you'll need: | ||
|
|
||
| - A [Meilisearch Cloud](https://www.meilisearch.com/cloud) project running version >=1.13 | ||
| - A Google account with an API key for embedding generation. You can sign up for a Google account at [Google](https://google.com/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - A Google account with an API key for embedding generation. You can sign up for a Google account at [Google](https://google.com/). | |
| - A Google account with an API key for embedding generation. You can sign up for a Google account at [Google](https://google.com/) |
|
|
||
| - A [Meilisearch Cloud](https://www.meilisearch.com/cloud) project running version >=1.13 | ||
| - A Google account with an API key for embedding generation. You can sign up for a Google account at [Google](https://google.com/). | ||
| - No backend required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of specifying something isn't required in the requirements section. (I know the other AI guides do that, but it's something I want to change when I have the time).
| - No backend required. |
Pull Request
Related issue
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!