Combine train sound selector and large counter - #166
Open
vbonaci wants to merge 4 commits into
Open
Conversation
Let users pick between choo-choo and SF Muni chime sounds, and document how to add more in the README. Co-authored-by: Cursor <cursoragent@cursor.com>
…unter' into 3-next-steps-54229015 # Conflicts: # index.html
Author
|
@mattppal could you review and merge this when you have a chance? The branch combines PR #100 and PR #101, resolves their conflict, and includes a follow-up fix to make the dispatch flow visible. @LewisJEllis if this should be handled by me directly, can you grant @vbonaci the repo access needed to approve/merge this PR or enable auto-merge? Current permission is read-only, so GitHub blocks approval, normal merge, admin merge, and auto-merge from this account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note: local node is not installed in this workspace, and the Node REPL disallows string code generation, so inline JS parse validation could not be run that way.