Skip to content

Add reasoning_effort parameter support for reasoning models (#3651) #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add reasoning_effort parameter support for reasoning models (#3651) #3686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions mem0/llms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@

from mem0.configs.llms.base import BaseLlmConfig


class LLMBase(ABC):
"""
Base class for all LLM providers.
Handles common functionality and delegates provider-specific logic to subclasses.
"""

def __init__(self, config: Optional[Union[BaseLlmConfig, Dict]] = None):
"""Initialize a base LLM class
"""
Initialize a base LLM class

:param config: LLM configuration option class or dict, defaults to None
:type config: Optional[Union[BaseLlmConfig, Dict]], optional
Expand All @@ -24,6 +24,10 @@ def __init__(self, config: Optional[Union[BaseLlmConfig, Dict]] = None):
else:
self.config = config

# Add reasoning_effort to config if not already present
if not hasattr(self.config, "reasoning_effort"):
self.config.reasoning_effort = None # Default value if not set

# Validate configuration
self._validate_config()

Expand Down Expand Up @@ -54,14 +58,11 @@ def _is_reasoning_model(self, model: str) -> bool:
"o1", "o1-preview", "o3-mini", "o3",
"gpt-5", "gpt-5o", "gpt-5o-mini", "gpt-5o-micro",
}

if model.lower() in reasoning_models:
return True

model_lower = model.lower()
if any(reasoning_model in model_lower for reasoning_model in ["gpt-5", "o1", "o3"]):
return True

return False

def _get_supported_params(self, **kwargs) -> Dict:
Expand All @@ -76,10 +77,8 @@ def _get_supported_params(self, **kwargs) -> Dict:
Dict: Filtered parameters dictionary
"""
model = getattr(self.config, 'model', '')

if self._is_reasoning_model(model):
supported_params = {}

if "messages" in kwargs:
supported_params["messages"] = kwargs["messages"]
if "response_format" in kwargs:
Expand All @@ -88,7 +87,9 @@ def _get_supported_params(self, **kwargs) -> Dict:
supported_params["tools"] = kwargs["tools"]
if "tool_choice" in kwargs:
supported_params["tool_choice"] = kwargs["tool_choice"]

# NEW: Add reasoning_effort if set in config
if hasattr(self.config, "reasoning_effort") and self.config.reasoning_effort is not None:
supported_params["reasoning_effort"] = self.config.reasoning_effort
return supported_params
else:
# For regular models, include all common parameters
Expand Down