feat: deprecate meshstack_tenant in favor of meshstack_tenant_v4#217
Open
grubmeshi wants to merge 1 commit into
Open
feat: deprecate meshstack_tenant in favor of meshstack_tenant_v4#217grubmeshi wants to merge 1 commit into
grubmeshi wants to merge 1 commit into
Conversation
📊 Test Coverage
Uncovered functions (combined run)Combined with |
The meshstack_tenant resource does not expose the tenant uuid, which meshstack_building_block requires to target a tenant. Only meshstack_tenant_v4 exposes uuid/ref, so add a DeprecationMessage steering users to it. There is no automatic state migration between the two resource types (no state mover), so the message points users to importing into meshstack_tenant_v4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
grubmeshi
force-pushed
the
feature/deprecate-tenant-resource
branch
from
8ac711f to
1e9539e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deprecate the legacy
meshstack_tenantresource in favor ofmeshstack_tenant_v4.Why
Only
meshstack_tenant_v4exposes the tenantuuid(and aref), whichmeshstack_building_blockrequires to target a tenant (
target_reffor ameshTenantneeds a uuid).meshstack_tenantcannot be used to wire up building blocks, so it should no longer be the default choice.
Changes
DeprecationMessageto themeshstack_tenantresource schema pointing atmeshstack_tenant_v4. Terraform/OpenTofu now emit a deprecation warning when the resource is used.v0.23.1section with aDEPRECATIONSentry.Migration note
There is no automatic state migration between the two resource types (no state mover /
movedsupport), so the message tells users to move existing tenants over by importing them into
meshstack_tenant_v4rather than promising amovedblock.Validation
go build ./...,task lint(0 issues),task testtenant suite (mock) all green.task generateis a no-op for docs — the repo's doc template doesn't render resource-levelDeprecationMessage(same as the already-deprecatedmeshstack_buildingblock).🤖 Generated with Claude Code