Make SAAS prior sampleable #3105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@SamuelGabriel has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86770833. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3105 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 219 219
Lines 21174 21182 +8
=======================================
+ Hits 21172 21180 +8
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Dec 8, 2025
Summary: I want to sample datasets from the SAAS prior. This is only a draft PR to ask whether this should yield the right datasets, I would engineer things a little nicer + of course add tests if this looks good david. Differential Revision: D86770833
SamuelGabriel
force-pushed
the
export-D86770833
branch
from
e4e39a3 to
12ba357
Compare
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Dec 8, 2025
Summary: I want to sample datasets from the SAAS prior. This is only a draft PR to ask whether this should yield the right datasets, I would engineer things a little nicer + of course add tests if this looks good david. Differential Revision: D86770833
SamuelGabriel
force-pushed
the
export-D86770833
branch
from
12ba357 to
7d755ea
Compare
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Dec 9, 2025
Summary: I want to sample datasets from the SAAS prior. This is only a draft PR to ask whether this should yield the right datasets, I would engineer things a little nicer + of course add tests if this looks good david. Differential Revision: D86770833
SamuelGabriel
force-pushed
the
export-D86770833
branch
from
7d755ea to
1203156
Compare
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Dec 9, 2025
Summary: I want to sample datasets from the SAAS prior. This is only a draft PR to ask whether this should yield the right datasets, I would engineer things a little nicer + of course add tests if this looks good david. Differential Revision: D86770833
SamuelGabriel
force-pushed
the
export-D86770833
branch
2 times, most recently
from
656b77f to
54644d6
Compare
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Dec 10, 2025
Summary: I want to sample datasets from the SAAS prior. This is only a draft PR to ask whether this should yield the right datasets, I would engineer things a little nicer + of course add tests if this looks good david. Differential Revision: D86770833
Summary: I want to sample datasets from the SAAS prior. This is only a draft PR to ask whether this should yield the right datasets, I would engineer things a little nicer + of course add tests if this looks good david. Reviewed By: bletham Differential Revision: D86770833
SamuelGabriel
force-pushed
the
export-D86770833
branch
from
54644d6 to
58f1a60
Compare
|
This pull request has been merged in abb09b6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I want to sample datasets from the SAAS prior.
This is only a draft PR to ask whether this should yield the right datasets, I would engineer things a little nicer + of course add tests if this looks good david.
Differential Revision: D86770833