: host: simplify map to set #2044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88300708. |
Summary: this is a small simplification: the spawned procs' `ChannelAddr`s already live in `router: DialMailboxRouter`, so keeping a `HashMap<String, ChannelAddr>` in `procs` was redundant. switching `procs` to a `HashSet<String>` makes it clear that its only responsibility is guarding against duplicate proc names; routing remains the router's job. Differential Revision: D88300708
shayne-fletcher
force-pushed
the
export-D88300708
branch
from
885b305 to
12d3eaa
Compare
|
This pull request has been merged in 65bb906. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: this is a small simplification: the spawned procs'
ChannelAddrs already live inrouter: DialMailboxRouter, so keeping aHashMap<String, ChannelAddr>inprocswas redundant. switchingprocsto aHashSet<String>makes it clear that its only responsibility is guarding against duplicate proc names; routing remains the router's job.Differential Revision: D88300708