Unify All Launch Indices to 0-based #211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support .ndjson.gz (gzip compressed) files - Support .bin.ndjson (gzip member concatenation) files - Add _is_gzip_file() helper function - Add test using existing .ndjson.gz test file
- Create tritonparse/info/ module with kernel_query.py - Implement list_kernels() to list all kernels with launch counts - Implement find_launch_index_by_kernel() to find launch events by kernel name and launch ID - Add KernelSummary and LaunchInfo dataclasses - Add 6 unit tests in TestTritonparseCPU class - Tests use real data from example_output when possible, mock data otherwise This is PR3 from the design doc, providing the foundation for PR4 (reproduce --kernel/--launch-id).
- Moved the import of `find_launch_index_by_kernel` to the correct location in `tritonparse/info/__init__.py`. - Removed an unnecessary empty line in `tritonparse/info/kernel_query.py`. This change improves code organization and maintains clarity in the module's interface.
- Add --kernel and --launch-id CLI arguments to reproducer - Add mutual exclusivity check between --line and --kernel/--launch-id - Extend reproduce() function to support kernel name lookup - Use find_launch_index_by_kernel() from info module to find launch events - Add 5 unit tests for new functionality - Refactor tests to use helper methods following TestTritonparseCUDA pattern - Update docstring to document support for .ndjson, .ndjson.gz, and .bin.ndjson formats This is PR4 from the design doc, enabling users to reproduce kernels by name and launch ID instead of manually finding line numbers.
- Add info subcommand to query kernel information from trace files - Implement list_kernels_fast() using launch_diff events for optimization - Implement list_launches_for_kernel() to list all launches for a kernel - Implement find_similar_kernels() for fuzzy matching suggestions - Add parse_and_compress_raw_log() helper to auto-parse raw logs - Auto-detect raw logs and parse them automatically with compression - Add 4 comprehensive tests (1 unit test + 3 integration tests) - Reuse parse module's gzip compression functionality This is PR5 from the design doc, enabling users to query kernel information without manually parsing trace files.
- Change trace_processor.py to store 0-based line indices in launch_index_map - Update website components to display 0-based indices (remove +1 conversions) - Update KernelOverview.tsx comment from '1-based' to '0-based' - Update DiffViewer.tsx, StackDiffViewer.tsx, ArgumentViewer.tsx to show 0-based launch indices This makes all launch indices consistent with Python conventions and the existing 0-based indexing used in the info module and reproduce command. Breaking change: Website will now display 0-based line numbers and launch indices instead of 1-based.
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR unifies all launch indices across the codebase to use 0-based indexing, making them consistent with Python conventions and the existing 0-based indexing used in the
infomodule andreproducecommand.Changes
tritonparse/trace_processor.py:(parsed_json, i + 1)to(parsed_json, i)on line 304launch_index_mapnow stores 0-based line indices instead of 1-basedwebsite/src/pages/KernelOverview.tsx:website/src/components/DiffViewer.tsx:+ 1conversion when displaying launch rangeswebsite/src/components/StackDiffViewer.tsx:+ 1conversion when displaying launch rangeswebsite/src/components/ArgumentViewer.tsx:+ 1conversion when displaying launch rangesBreaking Change
Website Display: The website will now display 0-based line numbers and launch indices instead of 1-based. Users viewing launch information will see:
Rationale
infomodule,reproducecommand already use 0-based)Testing
Existing tests continue to pass. The change affects display format only, not core functionality.