fix: stamp release binaries with version, commit, date and builder - #1764
Open
Eljees wants to merge 1 commit into
Open
fix: stamp release binaries with version, commit, date and builder#1764Eljees wants to merge 1 commit into
Eljees wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #787.
cli/main.goexpects its version metadata in package-level variables —cli.version,cli.commit,cli.date,cli.builtBy— but.goreleaser.ymlhas noldflagssection, so releases get GoReleaser's default stamping ofmain.versionet al., which lands in the wrong package and leaves the variables at their defaults. TheBUILDER=GoReleaserbuild env declared there is not read by anything; it is removed.One honest note: the symptom has drifted since the issue was filed. Go now embeds VCS build info, so an unstamped binary reports a pseudo-version rather than the
(devel)from 2023:With the ldflags from this change (same
-Xpaths, sample values):-s -wis kept explicitly because overridingldflagsreplaces GoReleaser's defaults rather than extending them.AI-assisted (LLM used for drafting); the runs above are mine.