Avalonia 12.1.1 - #532
Merged
Merged
Conversation
Taken now rather than at the next release so it gets a whole cycle of use before it ships. Builds clean, the suites pass, the app runs. Popups now position on the screen containing their anchor point (#21750), which for a tool whose whole subject is multi-monitor geometry is the change to watch. It also brings ToolTip.ShouldUseOverlayLayer (#21830): a tooltip rendered inside its parent window has no top-level of its own for the OS to route a click to, which is the mechanism that was missing when the toolbar tips were swallowing clicks. The placement and delay put in for #528 stay as they are for now — the simplification is worth trying on top, once this has proven itself. Also bumps HLab.Sys.Argyll and the HLab.Avalonia submodule (mgth/HLab.Avalonia). DataGrid stays at 12.1.0, which has no 12.1.1 and does not need one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken now rather than at the next release, so it gets a whole cycle of use before it ships to anyone. Builds clean, all four suites pass, the app runs.
What is in it
Popups now position on the screen containing their anchor point (#21750) — for a tool whose entire subject is multi-monitor geometry, that is the change to keep an eye on. Plus custom hit-test,
Grid,ComboBox,ListBoxandTextBoxfixes.ToolTip.ShouldUseOverlayLayer(#21830) renders a tooltip inside its parent window instead of a top-level of its own. When #528 went in, the answer to "can a tooltip be made not to swallow clicks?" was no — verified against 12.1.0's API surface, where nothing onToolTiptouches hit testing. Two days later 12.1.1 shipped exactly that knob: with no separate window, there is no window for the OS to route the click to.The placement and 700 ms delay put in for #528 stay as they are here. They work, and swapping a working fix for an untried one on the same branch as a dependency bump would muddle what is being tested. Worth trying on top once this has settled.
Not bumped
Avalonia.Controls.DataGridstays at 12.1.0 — it publishes on its own cadence, has no 12.1.1, and asks forAvalonia >= 12.1.0, which 12.1.1 satisfies. It is pulled transitively by half the plugin projects, so bumping it blindly fails the restore.The
HLab.Localization.Avalonia2andHLab.Notify.Avaloniaprojects still sit on 11.x and are untouched: neither is in the solution.Tests
111 + 129 + 60 + 5 managed, 56 Rust.