XRechnung - FormatDecimal with Two Decimal Places

[pri-kise]

Summary

Provide an intergration Event in XRechnung Export to always include two decimals for Amount fields

Work Item(s)

Fixes #29717

Fixes AB#626471

[github-actions]

Issue #29717 is not valid. Please make sure you link an issue that exists, is open and is approved.

[miljance]

@pri-kise
Overall, I like the direction of this change. That said, I think it may be incomplete.
The flag name AlwaysIncludeTwoDecimalPlacesForAmountFields makes it clear this only applies to amount fields - which is fine. My concern is a potential inconsistency: while an amount would now correctly render as 5,00, the Unit Price could still render as 5, since it's not covered by this flag. Do you see that as a problem or you that is not perceived as a problem?

[pri-kise]

@pri-kise
Overall, I like the direction of this change. That said, I think it may be incomplete.
The flag name AlwaysIncludeTwoDecimalPlacesForAmountFields makes it clear this only applies to amount fields - which is fine. My concern is a potential inconsistency: while an amount would now correctly render as 5,00, the Unit Price could still render as 5, since it's not covered by this flag. Do you see that as a problem or you that is not perceived as a problem?

That's good input. I'll discuss this with my colleague

[pri-kise]

@miljance I've updated the PR to include at least two decimals for unit price too.

[miljance]

@miljance I've updated the PR to include at least two decimals for unit price too.

Looks much better, thanks. One question though. Why do you pass the global variable to all the functions? Is it because the functions FormatDecimalUnlimited and FormatDecimal can also be called from outside? AI agrees with this :).
In my eyes I was thinking if that many changes in the codeunit are needed in order to achieve reacting to a global flag on two places in the code.

The function name CheckShouldIncludeTwoDecimalPlacesForAmountFields sounds weird. Nothing is being checked with it, right? Suggestions: InitializeDecimalFormatFlags or SetDecimalPlacesFlags (suggestions from AI).