Use workspace for internal package reference - #52
Merged
Rahul Devikar (rahuldevikar761) merged 14 commits intoNov 13, 2025
Conversation
Rahul Devikar (rahuldevikar761)
requested a review
from a team
as a code owner
November 12, 2025 03:24
Copilot started reviewing on behalf of
Rahul Devikar (rahuldevikar761)
November 12, 2025 03:25
View session
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates internal package references to use the workspace:* protocol instead of wildcards (*) or placeholder versions (0.0.0-placeholder). This standardizes dependency management for internal packages within the monorepo, ensuring that pnpm properly resolves workspace dependencies.
Key changes:
- All internal
@microsoft/agents-a365-*package references now useworkspace:*protocol - Removed the
overridessection from pnpm-lock.yaml as these are no longer needed with workspace protocol - Updated lockfile reflects the new dependency resolution strategy
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/package.json | Updated three internal package references to use workspace protocol |
| tests-agent/openai-agent-auto-instrument-sample/package.json | Updated four internal package references to use workspace protocol |
| tests-agent/basic-agent-sdk-sample/package.json | Updated two internal package references to use workspace protocol |
| pnpm-lock.yaml | Removed overrides section and updated all internal package specifiers to workspace protocol throughout the lockfile |
| packages/agents-a365-tooling/package.json | Updated runtime package reference to use workspace protocol |
| packages/agents-a365-tooling-extensions-openai/package.json | Updated tooling and runtime package references to use workspace protocol |
| packages/agents-a365-tooling-extensions-langchain/package.json | Updated tooling and runtime package references to use workspace protocol |
| packages/agents-a365-tooling-extensions-claude/package.json | Updated tooling and runtime package references to use workspace protocol |
| packages/agents-a365-observability/package.json | Updated runtime package reference to use workspace protocol |
| packages/agents-a365-observability-extensions-openai/package.json | Updated observability package reference to use workspace protocol |
| packages/agents-a365-notifications/package/package.json | New package.json file with placeholder version for runtime dependency (should use workspace protocol) |
| packages/agents-a365-notifications/package.json | Updated runtime package reference to use workspace protocol |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Copilot started reviewing on behalf of
Rahul Devikar (rahuldevikar761)
November 12, 2025 03:50
View session
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Rahul Devikar (rahuldevikar761)
November 12, 2025 04:57
View session
Copilot started reviewing on behalf of
Rahul Devikar (rahuldevikar761)
November 12, 2025 05:12
View session
Copilot started reviewing on behalf of
Rahul Devikar (rahuldevikar761)
November 12, 2025 05:17
View session
Copilot started reviewing on behalf of
Rahul Devikar (rahuldevikar761)
November 12, 2025 23:01
View session
Julio Carlos Menendez (juliomenendez)
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.