Add initial implementation of DispatcherAgent with configuration and telemetry support - #59
Draft
MattB (MattB-msft) wants to merge 4 commits into
Draft
Add initial implementation of DispatcherAgent with configuration and telemetry support#59MattB (MattB-msft) wants to merge 4 commits into
MattB (MattB-msft) wants to merge 4 commits into
Conversation
|
|
||
| app.Run(); | ||
|
|
||
| static void BotSetup(IHostApplicationBuilder builder) |
There was a problem hiding this comment.
Why this instead of ServiceCollectionExtensions.AddBot and adding additional DI separately?
Contributor
|
I'm seeing some warnings |
| "Microsoft.AspNetCore": "Warning" | ||
| } | ||
| } | ||
| /* |
Contributor
There was a problem hiding this comment.
Comments are not permitted in JSON, and shows errors in VSCode
|
|
||
| namespace DispatcherAgent.Utils | ||
| { | ||
| public static class Utilities |
Contributor
There was a problem hiding this comment.
Can we split the methods in this class to other classes with better names? Seems to me the methods to get the conversation links should be in a different class that then ones related to oauth flows
| builder.Services.AddHttpClient(); | ||
|
|
||
| // Add AspNet Authentication suitable for token validation for a Bot Service bot (ABS- or SMBA) | ||
| builder.Services.AddBotAspNetAuthentication(builder.Configuration); |
There was a problem hiding this comment.
this line throws NRE if config is not set
Member
|
MattB (@MattB-msft) Do we still need this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the DispatcherAgent with essential models, configuration files, and telemetry capabilities to facilitate bot interactions and performance tracking.