Skip to content

Bugs/624365 [Quality Management] [28.x] Use existing open inspection default… #7203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexei-dobriansky wants to merge 1 commit into
base: releases/28.x
Choose a base branch
from
+18 −0
Open

Bugs/624365 [Quality Management] [28.x] Use existing open inspection default… #7203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Apps/W1/Quality Management/app/src/Setup/QltyManagementSetup.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ table 20400 "Qlty. Management Setup"
{
Caption = 'Inspection Creation Option';
ToolTip = 'Specifies whether and how a new quality inspection is created if existing inspections are found.';
InitValue = "Use existing open inspection if available";
}
field(5; "Inspection Search Criteria"; Enum "Qlty. Inspect. Search Criteria")
{
Expand Down
8 changes: 8 additions & 0 deletions src/Apps/W1/Quality Management/test/src/QltyTestsProdIntegr.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ codeunit 139966 "Qlty. Tests - Prod. Integr."
var
ReUsedProdOrderLine: Record "Prod. Order Line";
LibraryAssert: Codeunit "Library Assert";
LibrarySetupStorage: Codeunit "Library - Setup Storage";
QltyInspectionUtility: Codeunit "Qlty. Inspection Utility";
GenQltyProdOrderGenerator: Codeunit "Qlty. Prod. Order Generator";
LibraryInventory: Codeunit "Library - Inventory";
Expand Down Expand Up @@ -2070,6 +2071,7 @@ codeunit 139966 "Qlty. Tests - Prod. Integr."
Item: Record Item;
ProdProductionOrder: Record "Production Order";
ProdOrderRoutingLine: Record "Prod. Order Routing Line";
QltyManagementSetup: Record "Qlty. Management Setup";
BeforeCount: Integer;
CountOfRoutingLines: Integer;
begin
Expand All @@ -2078,6 +2080,10 @@ codeunit 139966 "Qlty. Tests - Prod. Integr."

// [GIVEN] Quality management setup exists
QltyInspectionUtility.EnsureSetupExists();
LibrarySetupStorage.Save(Database::"Qlty. Management Setup");
QltyManagementSetup.Get();
QltyManagementSetup."Inspection Creation Option" := QltyManagementSetup."Inspection Creation Option"::"Always create new inspection";
QltyManagementSetup.Modify();

// [GIVEN] A quality inspection template is created with 3 lines
QltyInspectionUtility.CreateTemplate(QltyInspectionTemplateHdr, 3);
Expand Down Expand Up @@ -2107,6 +2113,8 @@ codeunit 139966 "Qlty. Tests - Prod. Integr."

// [THEN] Inspections are created for each routing line
LibraryAssert.AreEqual(BeforeCount + CountOfRoutingLines, QltyInspectionHeader.Count(), 'Inspection(s) was not created.');

LibrarySetupStorage.Restore();
end;

[Test]
Expand Down
9 changes: 9 additions & 0 deletions src/Apps/W1/Quality Management/test/src/QltyTestsReceivingInteg.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ codeunit 139958 "Qlty. Tests - Receiving Integ."
LibraryAssert: Codeunit "Library Assert";
LibraryERMCountryData: Codeunit "Library - ERM Country Data";
QltyInspectionUtility: Codeunit "Qlty. Inspection Utility";
LibrarySetupStorage: Codeunit "Library - Setup Storage";
IsInitialized: Boolean;

[Test]
Expand Down Expand Up @@ -1332,6 +1333,7 @@ codeunit 139958 "Qlty. Tests - Receiving Integ."
QltyInspectionTemplateHdr: Record "Qlty. Inspection Template Hdr.";
QltyInspectionGenRule: Record "Qlty. Inspection Gen. Rule";
QltyInspectionHeader: Record "Qlty. Inspection Header";
QltyManagementSetup: Record "Qlty. Management Setup";
Item: Record Item;
Vendor: Record Vendor;
PurOrderPurchaseHeader: Record "Purchase Header";
Expand All @@ -1349,6 +1351,11 @@ codeunit 139958 "Qlty. Tests - Receiving Integ."
Initialize();
LibraryWarehouse.CreateLocationWMS(Location, false, false, false, false, false);
QltyInspectionUtility.EnsureSetupExists();
LibrarySetupStorage.Save(Database::"Qlty. Management Setup");
QltyManagementSetup.Get();
QltyManagementSetup."Inspection Creation Option" := QltyManagementSetup."Inspection Creation Option"::"Always create new inspection";
QltyManagementSetup.Modify();

QltyInspectionUtility.CreateTemplate(QltyInspectionTemplateHdr, 3);
QltyInspectionGenRule.DeleteAll();
QltyInspectionUtility.CreatePrioritizedRule(QltyInspectionTemplateHdr, Database::"Purchase Line", QltyInspectionGenRule);
Expand Down Expand Up @@ -1387,6 +1394,8 @@ codeunit 139958 "Qlty. Tests - Receiving Integ."
LibraryAssert.AreEqual(QltyInspectionTemplateHdr.Code, QltyInspectionHeader."Template Code", 'Template code should match provided template');
LibraryAssert.AreEqual(50, QltyInspectionHeader."Source Quantity (Base)", 'Inspection quantity(base) should match reservation entry quantity, not qty. to receive.');
until QltyInspectionHeader.Next() = 0;

LibrarySetupStorage.Restore();
end;

[Test]
Expand Down
Loading