Skip to content

[releases/28.0] [Shopify] When deleting a Shopify refund/return the Shopify refund/return line for all other refund/return are deleted#7427

Merged
onbuyuka merged 1 commit intoreleases/28.0from
bugs/629294-backport
Mar 30, 2026
Merged

[releases/28.0] [Shopify] When deleting a Shopify refund/return the Shopify refund/return line for all other refund/return are deleted#7427
onbuyuka merged 1 commit intoreleases/28.0from
bugs/629294-backport

Conversation

@onbuyuka
Copy link
Copy Markdown
Contributor

@onbuyuka onbuyuka commented Mar 27, 2026

Summary

Backport of bug #626081 to releases/28.0.

Fixes AB#629294

Original PR(s): #7320

## Summary
- **Bug 626081**: Deleting a single Shopify refund or return header
deletes lines for **all** refunds/returns, not just the deleted one
- **Root cause**: `SetRange("Field Name")` in `OnDelete` triggers was
called without a value parameter, which clears the filter instead of
setting it — causing `DeleteAll` to wipe the entire line table
- **Fix**: Pass `Rec."Refund Id"` / `Rec."Return Id"` as the second
parameter to `SetRange` in 3 locations across 2 files

Fixes
[AB#626081](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/626081)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@onbuyuka onbuyuka requested a review from a team as a code owner March 27, 2026 12:01
@github-actions github-actions bot added the AL: Apps (W1) Add-on apps for W1 label Mar 27, 2026
@github-actions github-actions bot added this to the Version 28.0 milestone Mar 27, 2026
@onbuyuka onbuyuka enabled auto-merge (squash) March 27, 2026 12:03
Copy link
Copy Markdown
Contributor

@darjoo darjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: version-tagged backport.

@onbuyuka onbuyuka merged commit 850bcf0 into releases/28.0 Mar 30, 2026
36 checks passed
@onbuyuka onbuyuka deleted the bugs/629294-backport branch March 30, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants