Skip to content

fix: main to dev - downmerge - Update CODEOWNERS and improve ACR image build scripts - #1003

Merged
Avijit-Microsoft merged 15 commits into
devfrom
main
Jul 17, 2026
Merged

fix: main to dev - downmerge - Update CODEOWNERS and improve ACR image build scripts#1003
Avijit-Microsoft merged 15 commits into
devfrom
main

Conversation

@Pavan-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request updates the project to use the new gpt-5.2 model by default and improves the container deployment workflow. The main changes include switching all references, parameters, and deployment scripts from gpt-4o-mini to gpt-5.2, updating default regions and model versions, and enhancing the deployment process to use Azure Container Registry (ACR) for building and pushing backend and frontend images. Additionally, documentation and infrastructure files have been updated to reflect these changes and to clarify the new container image build and deployment steps.

Model and Region Updates

  • Default GPT model is now gpt-5.2 (was gpt-4o-mini), with updated default version 2025-12-11 and deployment type references throughout documentation and infrastructure files. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Default secondary region changed to australiaeast (was eastus2) in both parameters and documentation. [1] [2]

Container Image Build and Deployment Enhancements

  • Added scripts and documentation to guide users through building and pushing backend and frontend images to Azure Container Registry (ACR), replacing the use of static image references. [1] [2] [3]
  • Infrastructure (main.bicep) now configures App Services to use images from ACR with managed identity and sets up required private DNS zones for ACR access. [1] [2] [3] [4] [5]

Parameter and Metadata Cleanup

  • Updated or removed unused container registry parameters and image tag defaults to reflect the new deployment approach. [1] [2]
  • Cleaned up hardcoded registry values and improved tagging consistency for container images. [1] [2]

Documentation Improvements

  • Deployment and quota check guides now reference the new model, region, and image build steps, ensuring users follow the correct process for successful deployment. [1] [2] [3] [4]

These changes ensure the project is ready for the latest Azure OpenAI offerings and streamline the container deployment process for both development and production environments.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the accelerator’s default Azure OpenAI model/region configuration and shifts container deployment toward building and pushing images into a newly provisioned Azure Container Registry (ACR), with App Services configured to pull images via managed identity.

Changes:

  • Switched default GPT model settings from gpt-4o-mini to gpt-5.2 (and updated default model version/secondary region) across infra and docs.
  • Added an ACR remote-build workflow (az acr build) and post-deploy script to build/push backend + frontend images and update App Services.
  • Updated infra parameters and deployment guidance to align with the new image build/push flow and ACR private networking additions.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/App/WebApp.Dockerfile Refines multi-stage frontend build and Nginx runtime layout.
src/App/.dockerignore Ensures node_modules are excluded from Docker build context.
src/api/ApiApp.Dockerfile Switches base image and installs SQL Server ODBC driver via Debian packages.
README.md Updates resource table example model reference to GPT-5.2.
infra/scripts/quota_check_params.sh Updates default model/capacity list for quota checks.
infra/scripts/checkquota_km.sh Updates quota check mapping to OpenAI.GlobalStandard.gpt-5.2.
infra/scripts/build_and_push_images.sh New script to remote-build/push images in ACR and update App Services.
infra/main.waf.parameters.json Aligns image tag defaults and removes old registry hostname parameters.
infra/main.parameters.json Aligns image tag defaults and removes old registry hostname parameters.
infra/main.json Updates compiled ARM template with new defaults and ACR/managed identity wiring.
infra/main.bicep Updates defaults (model/region), adds ACR + private DNS zone, and sets MI-based pull config.
documents/re-use-foundry-project.md Updates default model mention to gpt-5.2.
documents/QuotaCheck.md Updates examples/defaults to gpt-5.2.
documents/DeploymentGuide.md Adds explicit “build and push container images” post-deploy step.
documents/CustomizingAzdParameters.md Updates default params and guidance for gpt-5.2 and image tag defaults.
documents/AzureGPTQuotaSettings.md Updates quota UI guidance to reference gpt-5.2.
azure.yaml Prints post-deploy guidance to run the new image build/push script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/api/ApiApp.Dockerfile
Comment thread infra/main.json
Comment thread infra/scripts/build_and_push_images.sh
Comment thread infra/scripts/build_and_push_images.sh
Comment thread infra/main.bicep
@Pavan-Microsoft
Pavan-Microsoft marked this pull request as draft July 17, 2026 04:09
@Pavan-Microsoft
Pavan-Microsoft marked this pull request as ready for review July 17, 2026 04:13
@Avijit-Microsoft
Avijit-Microsoft merged commit 9e95105 into dev Jul 17, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants