fix: main to dev - downmerge - Update CODEOWNERS and improve ACR image build scripts - #1003
Merged
Conversation
fix: dev to main - Update aiohttp version to 3.14.1 in requirements files
…dd a new script to build and push container images to Azure Container Registry.
…ntation and infrastructure files
co-author: Pavan Kumar
Co-author: Pavan Kumar
feat: Updated the infra for ACR and script for builing iamges
fix: Updated build_and_push_images.sh for WAF
chore: Update Owners ID for Vinay and Prajwal
Pavan-Microsoft
marked this pull request as ready for review
July 17, 2026 03:29
Pavan-Microsoft
requested review from
Roopan-Microsoft,
Anish Arora (aniaroramsft),
dgp10801,
nchandhi and
Todd Herman (toherman-msft)
as code owners
July 17, 2026 03:29
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the accelerator’s default Azure OpenAI model/region configuration and shifts container deployment toward building and pushing images into a newly provisioned Azure Container Registry (ACR), with App Services configured to pull images via managed identity.
Changes:
- Switched default GPT model settings from
gpt-4o-minitogpt-5.2(and updated default model version/secondary region) across infra and docs. - Added an ACR remote-build workflow (
az acr build) and post-deploy script to build/push backend + frontend images and update App Services. - Updated infra parameters and deployment guidance to align with the new image build/push flow and ACR private networking additions.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/App/WebApp.Dockerfile | Refines multi-stage frontend build and Nginx runtime layout. |
| src/App/.dockerignore | Ensures node_modules are excluded from Docker build context. |
| src/api/ApiApp.Dockerfile | Switches base image and installs SQL Server ODBC driver via Debian packages. |
| README.md | Updates resource table example model reference to GPT-5.2. |
| infra/scripts/quota_check_params.sh | Updates default model/capacity list for quota checks. |
| infra/scripts/checkquota_km.sh | Updates quota check mapping to OpenAI.GlobalStandard.gpt-5.2. |
| infra/scripts/build_and_push_images.sh | New script to remote-build/push images in ACR and update App Services. |
| infra/main.waf.parameters.json | Aligns image tag defaults and removes old registry hostname parameters. |
| infra/main.parameters.json | Aligns image tag defaults and removes old registry hostname parameters. |
| infra/main.json | Updates compiled ARM template with new defaults and ACR/managed identity wiring. |
| infra/main.bicep | Updates defaults (model/region), adds ACR + private DNS zone, and sets MI-based pull config. |
| documents/re-use-foundry-project.md | Updates default model mention to gpt-5.2. |
| documents/QuotaCheck.md | Updates examples/defaults to gpt-5.2. |
| documents/DeploymentGuide.md | Adds explicit “build and push container images” post-deploy step. |
| documents/CustomizingAzdParameters.md | Updates default params and guidance for gpt-5.2 and image tag defaults. |
| documents/AzureGPTQuotaSettings.md | Updates quota UI guidance to reference gpt-5.2. |
| azure.yaml | Prints post-deploy guidance to run the new image build/push script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pavan-Microsoft
marked this pull request as draft
July 17, 2026 04:09
Pavan-Microsoft
marked this pull request as ready for review
July 17, 2026 04:13
Avijit-Microsoft
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the project to use the new
gpt-5.2model by default and improves the container deployment workflow. The main changes include switching all references, parameters, and deployment scripts fromgpt-4o-minitogpt-5.2, updating default regions and model versions, and enhancing the deployment process to use Azure Container Registry (ACR) for building and pushing backend and frontend images. Additionally, documentation and infrastructure files have been updated to reflect these changes and to clarify the new container image build and deployment steps.Model and Region Updates
gpt-5.2(wasgpt-4o-mini), with updated default version2025-12-11and deployment type references throughout documentation and infrastructure files. [1] [2] [3] [4] [5] [6] [7] [8] [9]australiaeast(waseastus2) in both parameters and documentation. [1] [2]Container Image Build and Deployment Enhancements
main.bicep) now configures App Services to use images from ACR with managed identity and sets up required private DNS zones for ACR access. [1] [2] [3] [4] [5]Parameter and Metadata Cleanup
Documentation Improvements
These changes ensure the project is ready for the latest Azure OpenAI offerings and streamline the container deployment process for both development and production environments.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation