-
Notifications
You must be signed in to change notification settings - Fork 562
Update ESLint to version 9 in build-tools workspace #26070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/update-eslint-to-version-9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+790
−3,036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tylerbutler <[email protected]>
Co-authored-by: tylerbutler <[email protected]>
Co-authored-by: tylerbutler <[email protected]>
Copilot
AI
changed the title
[WIP] Update eslint to version 9 in build-tools workspace
Update ESLint to version 9 in build-tools workspace
Dec 17, 2025
Member
|
/azp run Build - protocol-definitions,Build - test-tools,server-gitrest,server-gitssh,server-routerlicious,Build - client packages,repo-policy-check,Build - build-tools |
Member
|
/azp run Build - api-markdown-documenter,Build - benchmark-tool,Build - build-common,Build - build-tools,Build - common-utils,Build - eslint-config-fluid,Build - eslint-plugin-fluid,server-historian |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the build-tools workspace from ESLint 8 to ESLint 9, adopting the new flat config format.
Key changes:
eslintfrom~8.57.0to~9.39.1across all build-tools packages.eslintrc.cjsfiles witheslint.config.mtsflat configs@eslint/js,typescript-eslint, andjitidependencies for ESLint 9 support@fluidframework/eslint-config-fluiddependency (replaced with direct typescript-eslint usage)eslint-config-oclifandeslint-config-oclif-typescript(simplified config)DEV.mdto remove ESLint 8 from blocked upgrades listBreaking Changes
None. Internal tooling change only.
Reviewer Guidance
The new flat configs intentionally use a simpler rule set than the previous
@fluidframework/eslint-config-fluidto match what the original configs were effectively using. Each package'seslint.config.mtsextends@eslint/jsrecommended +typescript-eslintrecommended, with package-specific overrides preserved from the original configs.Build passes, all ESLint checks pass. One pre-existing test failure in
fromTag.test.tsis unrelated to these changes.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.