build(client): check exactOptionalPropertyTypes=false#27566
Draft
jason-ha wants to merge 2 commits into
Draft
Conversation
Ensure that packages building with exactOptionalPropertyTypes-true (preferred) also support consumers that type check with exactOptionalPropertyType=false where an optional property might exist with `undefined`.
Contributor
Bundle size comparisonBase commit: The PR's CI build failed — fix the build and the comment will update once the next run succeeds. |
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (59 lines, 48 files), I've queued these reviewers:
How this works
|
Set `explicitExactOptionalPropertyTypes` in configs inheriting from `ts-common-config.json` except server/** packages that are still using package reference and was not investigated. This removes some `"check:inexactOptionalPropertyTypes"` entries that were erroneously added where it appears that `exactOptionalPropertyTypes` was enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that packages building with exactOptionalPropertyTypes-true (preferred) also support consumers that type check with exactOptionalPropertyType=false where an optional property might exist with
undefined.Exception: presence-runtime is excluded as it has always been built with exactOptionalPropertyTypes enabled and has errors otherwise. Likely it can be reworked to not depend on that with some altered checks - all appear to be internal logic anyway.
Note: there is a bug in TS 5.4.5 where altering a tsc command line after the command was run with errors will not regenerate the .tsbuildinfo file even on success and incremental builds will keep triggering. There is no expectation to change the command line to start resulting in success. If this happens before updating tsc, the workaround is to clean the impacted directory.