Add optional logger to Breakable and independent tree view objects#27567
Add optional logger to Breakable and independent tree view objects#27567jzaffiro wants to merge 3 commits into
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (86 lines, 6 files), I've queued these reviewers:
How this works
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| The alpha `independentView`, `independentInitializedView`, and `createIndependentTreeAlpha` APIs now accept an optional `logger` on their options. | ||
| Previously these standalone (non-`SharedTree`) views had no way to surface telemetry, | ||
| so internal events — including those emitted when the tree enters a broken state — were silently dropped. |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Microsoft.Dashes] Remove the spaces around ' — '.
|
|
||
| The alpha `independentView`, `independentInitializedView`, and `createIndependentTreeAlpha` APIs now accept an optional `logger` on their options. | ||
| Previously these standalone (non-`SharedTree`) views had no way to surface telemetry, | ||
| so internal events — including those emitted when the tree enters a broken state — were silently dropped. |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Microsoft.Dashes] Remove the spaces around ' — '.
|
|
||
| The alpha `independentView`, `independentInitializedView`, and `createIndependentTreeAlpha` APIs now accept an optional `logger` on their options. | ||
| Previously these standalone (non-`SharedTree`) views had no way to surface telemetry, | ||
| so internal events — including those emitted when the tree enters a broken state — were silently dropped. |
There was a problem hiding this comment.
[Microsoft.Adverbs] Remove 'silently' if it's not important to the meaning of the statement.
| The alpha `independentView`, `independentInitializedView`, and `createIndependentTreeAlpha` APIs now accept an optional `logger` on their options. | ||
| Previously these standalone (non-`SharedTree`) views had no way to surface telemetry, | ||
| so internal events — including those emitted when the tree enters a broken state — were silently dropped. | ||
| Passing a logger forwards those events to the caller's telemetry pipeline, |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Microsoft.SentenceLength] Try to keep sentences short (< 30 words).
Bundle size comparisonBase commit: The PR's CI build failed — fix the build and the comment will update once the next run succeeds. |
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Plumb an optional logger through the SharedTree Breakable object to support telemetry through all levels of the tree. Additionally, support logging on independent tree views by adding a logger to the options passed through the independent tree.
AB#73616
Reviewer Guidance
The review process is outlined on this wiki page.
Specifically, is there a better place to plumb telemetry through for an independent tree?