chore(claims): rename @fluidframework/claims to @fluid-internal/claims#27569
Draft
kian-thompson wants to merge 1 commit into
Draft
chore(claims): rename @fluidframework/claims to @fluid-internal/claims#27569kian-thompson wants to merge 1 commit into
kian-thompson wants to merge 1 commit into
Conversation
The claims DDS package has no public API surface (every export is tagged @internal). Rename it to @fluid-internal/claims to align the scope with its intended use as an implementation detail for other Fluid packages, matching the convention used by @fluid-internal/client-utils and @fluid-internal/presence-runtime. Also simplifies the exports map by removing the redundant ./internal subpath and the internal.d.ts types-resolution shim, since the entire package is internal and the root . entry point already exposes the full API. The test-only entry point stays under ./internal/test to match @fluid-internal/presence-runtime and remain within the npm-package-exports-apis-linted policy exemption. Updates @fluid-internal/local-server-stress-tests (the only in-repo consumer) to reference the new package name and subpath. Lockfile regenerated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (49 lines, 15 files), I've queued these reviewers:
How this works
|
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames the recently-added claims DDS package from
@fluidframework/claimsto@fluid-internal/claimsto align its scope with its intended use: an implementation detail for other Fluid packages, with no public API surface. Every export in the package is already tagged@internal, so the public/beta/alpha API reports are empty — the@fluid-internalscope makes this explicit and matches the convention used by@fluid-internal/client-utils,@fluid-internal/presence-runtime, and similar packages.The change also simplifies the package's
exportsmap. Because the entire package is internal, the standard.vs./internalsplit is meaningless here. This PR:./internalexport subpath (the root.entry point already exposes the full internal API).internal.d.tstypes-resolution shim that existed only to support the./internalsubpath undernode16/bundlermodule resolution../internal/testto match@fluid-internal/presence-runtimeand stay within thenpm-package-exports-apis-lintedpolicy exemption for./internal/*subpaths.Updates the only in-repo consumer (
@fluid-internal/local-server-stress-tests) to reference the new package name and updated subpath. Lockfile regenerated. No functional changes.Reviewer Guidance
The review process is outlined on this wiki page.