Skip to content

fix: clarify output directory naming to use workspace root basename#1990

Merged
saikoumudi merged 2 commits into
microsoft:mainfrom
MadhuraBharadwaj-MSFT:fix/output-dir-naming-1927
Apr 22, 2026
Merged

fix: clarify output directory naming to use workspace root basename#1990
saikoumudi merged 2 commits into
microsoft:mainfrom
MadhuraBharadwaj-MSFT:fix/output-dir-naming-1927

Conversation

@MadhuraBharadwaj-MSFT
Copy link
Copy Markdown
Collaborator

Fixes #1927 - Agent was using subdirectory names (e.g. todo-src-azure) instead of workspace root name for the output directory.

  • Replace ambiguous and placeholders with explicit across all skill reference files
  • Add clarification that it refers to the top-level workspace directory, NOT a subdirectory within it

Description

Checklist

  • Tests pass locally (cd tests && npm test)
  • If modifying skill descriptions: verified routing correctness with integration tests (npm run test:skills:integration -- <skill>)
  • If modifying skill USE FOR / DO NOT USE FOR / PREFER OVER clauses: confirmed no routing regressions for competing skills
  • Version bumped in skill frontmatter (if skill files changed)

Related Issues

Fixes microsoft#1927 - Agent was using subdirectory names (e.g. todo-src-azure) instead
of workspace root name for the output directory.

- Replace ambiguous <source-folder> and <aws-folder> placeholders with
  explicit <workspace-root-basename> across all skill reference files
- Add clarification that it refers to the top-level workspace directory,
  NOT a subdirectory within it
Copilot AI review requested due to automatic review settings April 21, 2026 21:12
@MadhuraBharadwaj-MSFT MadhuraBharadwaj-MSFT marked this pull request as draft April 21, 2026 21:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the azure-cloud-migrate skill documentation to unambiguously name the migration output directory using the workspace root directory basename, aligning guidance with the integration-test expectation behind #1927.

Changes:

  • Replaces ambiguous <source-folder> / <aws-folder> placeholders with <workspace-root-basename> across relevant azure-cloud-migrate references.
  • Clarifies that <workspace-root-basename> refers to the top-level workspace directory name, not a nested subdirectory name.
  • Keeps output artifact locations consistent in docs (e.g., migration-status.md, migration-assessment-report.md under <workspace-root-basename>-azure/).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
plugin/skills/azure-cloud-migrate/SKILL.md Clarifies output directory naming and reiterates creation of <workspace-root-basename>-azure/.
plugin/skills/azure-cloud-migrate/references/workflow-details.md Updates the status-tracking guidance to reference the clarified output directory placeholder.
plugin/skills/azure-cloud-migrate/references/services/functions/code-migration.md Updates Azure Functions code migration output-directory placeholder to <workspace-root-basename>-azure/.
plugin/skills/azure-cloud-migrate/references/services/functions/assessment.md Updates assessment report save location placeholder to <workspace-root-basename>-azure/.

Copy link
Copy Markdown
Collaborator

@jongio jongio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 5 occurrences of the old placeholders across the skill directory are covered - no stale references left.

Issues to address:

  • SKILL.md:7 - metadata.version is still 1.0.4. Repo convention requires a version bump when skill files change (.github/instructions/skill-files.instructions.md). Bump to 1.0.5.

@MadhuraBharadwaj-MSFT MadhuraBharadwaj-MSFT marked this pull request as ready for review April 21, 2026 21:49
@kvenkatrajan
Copy link
Copy Markdown
Collaborator

Code Review — PR #1990: Clarify output directory naming convention

✅ What Looks Good

  1. Consistent placeholder rename — All 5 occurrences of <source-folder> and <aws-folder> updated to <workspace-root-basename> across all 4 files
  2. Helpful clarification — The added note "(NOT a subdirectory within it)" directly addresses the ambiguity that caused the bug (Integration test failure: azure-cloud-migrate – Lambda webapp migration output directory [Assertion mismatch] #1927)
  3. No source directory changes — Correctly scoped to documentation only
  4. Container Apps references clean — GCP/Cloud Run references don't use the old placeholders, so no missed files
  5. SKILL.md stays well within token budget — ~611 tokens (limit: 5,000)

🟡 Medium

1. Version not bumped

  • File: plugin/skills/azure-cloud-migrate/SKILL.md
  • Issue: version is "0.0.0-placeholder" which is correct for plugin/skills/ (NBGV stamps at build), but version.json was not checked for a patch bump. Per repo convention, modified skills should increment their version.
  • Suggested Fix: Bump the patch version in plugin/skills/azure-cloud-migrate/version.json (e.g., from current to next patch).

🟢 Low

2. Pre-existing token budget exceedances (not introduced by this PR)

  • Files: lambda-to-functions.md (~2,666 tokens), cloudrun-deployment-guide.md (~2,082 tokens), javascript.md (~2,263 tokens)
  • Issue: These reference files exceed the 2,000-token hard limit. Not introduced by this PR — just flagging for awareness.

Summary

Severity Count
🔴 Critical 0
🟠 High 0
🟡 Medium 1
🟢 Low 1

Overall Assessment: Approve — Clean, well-scoped fix. The change correctly disambiguates the output directory naming and should resolve the issue described in #1927. The version bump is a minor process nit.

@kvenkatrajan
Copy link
Copy Markdown
Collaborator

kvenkatrajan commented Apr 22, 2026

@MadhuraBharadwaj-MSFT - you can skip incrementing the build version. As per the new build process this is auto incremented by the build process. @tmeschter clarified that the version.json increment is only for the major and minor versions which we dont need to be updating at this time. Thanks for the clarification @tmeschter

@MadhuraBharadwaj-MSFT you are good to merge when @saikoumudi approves

@saikoumudi saikoumudi merged commit efc80bd into microsoft:main Apr 22, 2026
12 checks passed
Ba4bes pushed a commit to Ba4bes/GitHub-Copilot-for-Azure that referenced this pull request Apr 24, 2026
…icrosoft#1990)

Fixes microsoft#1927 - Agent was using subdirectory names (e.g. todo-src-azure) instead
of workspace root name for the output directory.

- Replace ambiguous <source-folder> and <aws-folder> placeholders with
  explicit <workspace-root-basename> across all skill reference files
- Add clarification that it refers to the top-level workspace directory,
  NOT a subdirectory within it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration test failure: azure-cloud-migrate – Lambda webapp migration output directory [Assertion mismatch]

5 participants