fix: clarify output directory naming to use workspace root basename#1990
Conversation
Fixes microsoft#1927 - Agent was using subdirectory names (e.g. todo-src-azure) instead of workspace root name for the output directory. - Replace ambiguous <source-folder> and <aws-folder> placeholders with explicit <workspace-root-basename> across all skill reference files - Add clarification that it refers to the top-level workspace directory, NOT a subdirectory within it
There was a problem hiding this comment.
Pull request overview
Updates the azure-cloud-migrate skill documentation to unambiguously name the migration output directory using the workspace root directory basename, aligning guidance with the integration-test expectation behind #1927.
Changes:
- Replaces ambiguous
<source-folder>/<aws-folder>placeholders with<workspace-root-basename>across relevant azure-cloud-migrate references. - Clarifies that
<workspace-root-basename>refers to the top-level workspace directory name, not a nested subdirectory name. - Keeps output artifact locations consistent in docs (e.g.,
migration-status.md,migration-assessment-report.mdunder<workspace-root-basename>-azure/).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugin/skills/azure-cloud-migrate/SKILL.md | Clarifies output directory naming and reiterates creation of <workspace-root-basename>-azure/. |
| plugin/skills/azure-cloud-migrate/references/workflow-details.md | Updates the status-tracking guidance to reference the clarified output directory placeholder. |
| plugin/skills/azure-cloud-migrate/references/services/functions/code-migration.md | Updates Azure Functions code migration output-directory placeholder to <workspace-root-basename>-azure/. |
| plugin/skills/azure-cloud-migrate/references/services/functions/assessment.md | Updates assessment report save location placeholder to <workspace-root-basename>-azure/. |
jongio
left a comment
There was a problem hiding this comment.
All 5 occurrences of the old placeholders across the skill directory are covered - no stale references left.
Issues to address:
- SKILL.md:7 -
metadata.versionis still1.0.4. Repo convention requires a version bump when skill files change (.github/instructions/skill-files.instructions.md). Bump to1.0.5.
Code Review — PR #1990: Clarify output directory naming convention✅ What Looks Good
🟡 Medium1. Version not bumped
🟢 Low2. Pre-existing token budget exceedances (not introduced by this PR)
Summary
Overall Assessment: Approve — Clean, well-scoped fix. The change correctly disambiguates the output directory naming and should resolve the issue described in #1927. The version bump is a minor process nit. |
|
@MadhuraBharadwaj-MSFT - you can skip incrementing the build version. As per the new build process this is auto incremented by the build process. @tmeschter clarified that the version.json increment is only for the major and minor versions which we dont need to be updating at this time. Thanks for the clarification @tmeschter @MadhuraBharadwaj-MSFT you are good to merge when @saikoumudi approves |
…icrosoft#1990) Fixes microsoft#1927 - Agent was using subdirectory names (e.g. todo-src-azure) instead of workspace root name for the output directory. - Replace ambiguous <source-folder> and <aws-folder> placeholders with explicit <workspace-root-basename> across all skill reference files - Add clarification that it refers to the top-level workspace directory, NOT a subdirectory within it
Fixes #1927 - Agent was using subdirectory names (e.g. todo-src-azure) instead of workspace root name for the output directory.
Description
Checklist
cd tests && npm test)npm run test:skills:integration -- <skill>)USE FOR/DO NOT USE FOR/PREFER OVERclauses: confirmed no routing regressions for competing skillsRelated Issues