FIX Stop JSON retries for adversarial refusals - #2443
Merged
hannahwestra25 merged 9 commits intoAug 25, 2026
Merged
Conversation
Detect blocked and errored adversarial chat responses before schema parsing so terminal target failures do not consume the malformed-JSON retry budget. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hannahwestra25
marked this pull request as ready for review
August 20, 2026 21:59
hannahwestra25
changed the title
Contributor
Aren't they all using the same adv conv manager? |
Contributor
Author
yes updated the description! |
Roman Lutz (romanlutz)
approved these changes
Aug 22, 2026
Keep blocked, empty, processing, and unknown adversarial response semantics while treating each as terminal for JSON retry. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a7e5481-94f6-4cfe-97b4-441ad9b3939c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenAI structured refusals arrive as blocked/error
Messages, but the shared adversarial conversation manager parsed them as malformed JSON and exhausted the JSON retry budget.This change detects error responses before parsing, preserving their semantics: blocked responses raise
BadRequestExceptionwith the provider status/message, empty responses raiseEmptyResponseException, and processing/unknown failures raisePyritException. These terminal errors do not enter the JSON retry loop, while malformed normal responses still retry.Tests and Documentation
tyfor changed files.