Skip to content

[PERF]: execute XPIA injection handle activation concurrently #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prudhvi (apocalypse9949) wants to merge 4 commits into
base: main
Choose a base branch
from
+15 −3
Open

[PERF]: execute XPIA injection handle activation concurrently #165

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
620b49c
perf: execute XPIA injection handle activation concurrently
apocalypse9949 Aug 13, 2026
d8e7dfa
perf: execute XPIA injection handle activation concurrently
apocalypse9949 Aug 13, 2026
03d68da
perf: execute XPIA injection handle activation concurrently
apocalypse9949 Aug 13, 2026
74473b2
[PERF]: drop trial_groups from reports to avoid overlap with #121/#123
apocalypse9949 Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions rampart/attacks/_xpia.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,22 @@ async def _activate_handles_async(
Args:
stack (AsyncExitStack): The exit stack managing cleanup.
"""
for handle in self._handles:
await stack.enter_async_context(handle)

# Concurrent: total = max of all wait times
async def _enter_handle(h: InjectionHandle) -> None:

@nina-msft Nina Chikanov (nina-msft) Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter flagged: async function _enter_handle must be named with an _async suffix (e.g. _enter_handle_async) to pass through CI

await stack.enter_async_context(h)

# Concurrent context entry (network uploads)
try:
async with asyncio.TaskGroup() as tg:
for handle in self._handles:
tg.create_task(_enter_handle(handle))

@nina-msft Nina Chikanov (nina-msft) Aug 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskGroup cancels the remaining __aenter__ calls as soon as one handle fails. A sibling may already have created its remote payload but be cancelled before enter_async_context() can register its __aexit__, leaving that payload orphaned.

Please replace _enter_handle and the first TaskGroup block with a non-cancelling gather; this belongs directly in _activate_handles_async, before the existing readiness-wait block:

results = await asyncio.gather(
    *(stack.enter_async_context(handle) for handle in self._handles),
    return_exceptions=True,
)
errors = [result for result in results if isinstance(result, BaseException)]
if errors:
    raise errors[0]

# Keep the existing readiness TaskGroup here.

This preserves concurrent activation while allowing successful siblings to register cleanup.

Please also add unit tests: a regression test where one handle fails immediately and another finishes activation after a delay would cover the partial-failure case.

except ExceptionGroup as eg:
# Unwrap the first exception for cleaner error reporting.
# BaseExecution already catches and reports exceptions,
# but ExceptionGroup obscures the underlying InfrastructureError.
raise eg.exceptions[0] from eg
Comment thread
apocalypse9949 marked this conversation as resolved.

# Concurrent readiness wait (indexing delays)
async with asyncio.TaskGroup() as tg:
for handle in self._handles:
tg.create_task(handle.wait_until_ready())
Expand Down
Loading