Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
src/build/patches.ts
Outdated
| subtype: subType, | ||
| ...optionalMember("type", "string", typeValue), | ||
| subtype: | ||
| typeValue == "record" && typeof subType?.type !== "string" |
There was a problem hiding this comment.
I think this shouldn't check the type name. We could use this for any parameterized type, right?
There was a problem hiding this comment.
I think we should, when I removed that check, it broke the output to be:
readonly links: HTMLCollectionOf<HTMLAnchorElement, HTMLAreaElement>;
Instead of the original:
readonly links: HTMLCollectionOf<HTMLAnchorElement | HTMLAreaElement>;
There was a problem hiding this comment.
Oh no, ambiguate way to pass second type vs union. We need to disambiguate it rather than using the same way here then.
|
What do you think of the idea of adding the union property, like how I did it in the last commit? |
|
How do we handle |
I have searched the JSONC files and there is nothing like this. If there is an extremely rare case when this is needed, we can use overrideType |
2 participants
No description provided.