feat: Emit WebAssembly types separately from DOM types#959
Draft
ExE-Boss wants to merge 1 commit intomicrosoft:mainfrom
Draft
feat: Emit WebAssembly types separately from DOM types#959ExE-Boss wants to merge 1 commit intomicrosoft:mainfrom
ExE-Boss wants to merge 1 commit intomicrosoft:mainfrom
Conversation
ExE-Boss
commented
Dec 2, 2020
saschanaz
reviewed
Dec 4, 2020
Contributor
Author
9804caf to
071bb2c
Compare
3 tasks
|
@sandersn Any chance this can get reviewed? |
Contributor
Author
|
@saltman424 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #826
Note that I’d prefer if there was a way to filter based on the source WebIDL file, rather than the currentThis now uses a customFlavorconst enum approach.Exposedvalue ofWebAssembly, which is less hackish.Also,
namespace WebAssemblyshould be omitted fromdomandwebworkerapart fromcompileStreamingandinstantiateStreaming, which is why this leaves #826 open.Depends on:
fix(WebAssembly): Correct(merged)NativeErrorsubclass types #962See also:
declare classfor namespaced types #961WebAssembly.Globalgeneric #963domlib events out into separate lib for nodejs use TypeScript#43972review?(@saschanaz)