Hide Orleans provider annotation - #18975
Conversation
Keep OrleansProviderTypeAnnotation as internal implementation plumbing and test provider overrides through the public builder API. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25b57d9a-ff4a-4252-a7fc-d28d4fdde90f
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18975Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18975" |
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 1 / 100 test projects · 2 jobs, from 2 changed files. Selected test projects (1 / 100)
Selected jobs (2)
How these were chosen — grouped by what changed🔧 🧪 Job reasons
Selection computed for commit |
There was a problem hiding this comment.
Pull request overview
Hides Orleans provider annotation plumbing while preserving the public builder API.
Changes:
- Makes
OrleansProviderTypeAnnotationinternal. - Updates tests to validate generated Orleans configuration instead of internal annotations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Aspire.Hosting.Orleans/OrleansProviderTypeAnnotation.cs |
Restricts annotation visibility. |
tests/Aspire.Hosting.Orleans.Tests/OrleansProviderTypeTests.cs |
Removes tests coupled to annotation internals. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
✅ No documentation update needed. docs_optional → internal_refactor No signals triggered (signal_count = 0). The PR hides |
Description
Keeps
OrleansProviderTypeAnnotationas internal implementation plumbing while preservingWithOrleansProviderTypeas the supported public builder API.Tests now validate provider replacement through the resulting Orleans configuration rather than constructing or inspecting the internal annotation.
Addresses #17846 (comment).
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?