Fix Delve server API compatibility - #19081
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19081Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19081" |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 1 / 100 test projects · 3 jobs, from 9 changed files. Selected test projects (1 / 100)
Selected jobs (3)
How these were chosen — grouped by what changed🔧 🔧 🔧 🧪 🧪 Job reasons
Selection computed for commit |
Description
This follows up on #17846 to preserve binary compatibility while correcting the API shape of the preview-versioned
Aspire.Hosting.Gointegration.The shipped
WithDelveServer<T>(builder, int port = 2345)method remains as an obsolete binary compatibility shim and preserves its original single-client behavior. Supported C# callers now useWithDelveServer()for defaults orWithDelveServer(DelveServerOptions)for expanded configuration. The ATS-friendly DTO uses the correctedAcceptMultiClientcasing and defaults multi-client support tofalse.Only the DTO-based overload is exported to generated SDKs, avoiding overload collisions. The Go integration README and Go, Java, Python, and TypeScript polyglot fixtures reflect the generated API shape. Targeted tests assert the complete default, obsolete-port, and all-options Delve argument sequences.
User-facing usage
C# AppHost:
TypeScript AppHost:
Validation:
dotnet build src/Aspire.Hosting.Go/Aspire.Hosting.Go.csproj --no-restoredotnet test --project tests/Aspire.Hosting.Go.Tests/Aspire.Hosting.Go.Tests.csproj --no-launch-profile -- --filter-method "*DelveServer*" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"(20 passed)aspire sdk dump --format ci src/Aspire.Hosting.Go/Aspire.Hosting.Go.csprojAspire.Hosting.Gopolyglot AppHostsFixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?