Mark ResourceUrlAnnotation.DisplayOrder as obsolete - #19090
Mark ResourceUrlAnnotation.DisplayOrder as obsolete#19090Karol Zadora-Przylecki (karolz-ms) merged 5 commits into
Conversation
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Marks ResourceUrlAnnotation.DisplayOrder obsolete while preserving first-party compatibility.
Changes:
- Adds obsoletion guidance and scoped warning suppressions.
- Retains existing URL display-order behavior.
- Removes required Aspire SDK module declarations from Go AppHosts, breaking module resolution.
Reviewed changes
Copilot reviewed 59 out of 59 changed files in this pull request and generated 54 comments.
Show a summary per file
| File | Description |
|---|---|
tests/PolyglotAppHosts/Aspire.Hosting/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Yarp/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Valkey/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.SqlServer/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Seq/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Redis/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.RabbitMQ/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Qdrant/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Python/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.PostgreSQL/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Orleans/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Oracle/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.OpenAI/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Nats/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.MySql/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.MongoDB/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Milvus/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Maui/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Kubernetes/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Keycloak/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Kafka/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.JavaScript/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Go/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Garnet/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Foundry/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Dotnet/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Docker/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.DevTunnels/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Blazor/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.WebPubSub/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.Storage/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.Sql/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.SignalR/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.ServiceBus/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.Search/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.Redis/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.PostgreSQL/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.OperationalInsights/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.Network/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.Kusto/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.KeyVault/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.Functions/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.EventHubs/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.CosmosDB/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.ContainerRegistry/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.CognitiveServices/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.AppService/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.ApplicationInsights/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.AppContainers/Go/go.mod |
Removes required SDK module. |
tests/PolyglotAppHosts/Aspire.Hosting.Azure.AppConfiguration/Go/go.mod |
Removes required SDK module. |
tests/Aspire.Hosting.Tests/WithUrlsTests.cs |
Suppresses warnings while testing legacy behavior. |
src/Aspire.Hosting/Orchestrator/ApplicationOrchestrator.cs |
Preserves display-order propagation. |
src/Aspire.Hosting/Dcp/ResourceSnapshotBuilder.cs |
Preserves DCP URL display ordering. |
src/Aspire.Hosting/Dashboard/DashboardEventHandlers.cs |
Preserves dashboard URL ordering. |
src/Aspire.Hosting/ApplicationModel/ResourceUrlAnnotation.cs |
Marks DisplayOrder obsolete. |
src/Aspire.Cli/Templating/Templates/go-starter/go.mod |
Breaks generated Go starter resolution. |
playground/GoAppHost/go.mod |
Breaks playground module resolution. |
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19090Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19090" |
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 48 / 100 test projects · 4 jobs, from 5 changed files. Selected test projects (48 / 100)
Selected jobs (4)
How these were chosen — grouped by what changed
🔧 show 43
🧪 📦 affected project Job reasons
Selection computed for commit |
Description
ResourceUrlAnnotation.DisplayOrderwas incorrectly introduced as a field and will return as a property in a future Aspire version.Checklist
<remarks />and<code />elements on your triple slash comments?