Remove Publish-Build-Assets variable group from main - #19092
Open
Missy Messa (missymessa) wants to merge 2 commits into
Open
Remove Publish-Build-Assets variable group from main#19092Missy Messa (missymessa) wants to merge 2 commits into
Missy Messa (missymessa) wants to merge 2 commits into
Conversation
Remove the broad variable group import from repository-owned pipeline YAML. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ebdb92f2-4575-4676-853d-730c9d062f04
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19092Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19092" |
github-actions
Bot
added
the
area-engineering-systems
| @@ -47,7 +47,6 @@ variables: | |||
| # a branch the ACLs accept so manual / non-PR builds on ankj/* etc. can | |||
| # still validate the rest of the pipeline (including signing). | |||
| - ${{ if or(eq(variables['Build.SourceBranch'], 'refs/heads/main'), startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), startsWith(variables['Build.SourceBranch'], 'refs/heads/internal/release/')) }}: | |||
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ebdb92f2-4575-4676-853d-730c9d062f04
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
eng/pipelines/common-variables.yml:35
- Removing
Publish-Build-Assetsleaves the paragraph below referring to the BAR publish job and “these tokens,” even though this block now documents and loads only the Helix and SDL groups. Please remove the BAR-specific rationale so the comment accurately describes the remaining branch-gated groups.
# DotNet-HelixApi-Access provides: HelixApiAccessToken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the repository-owned
Publish-Build-Assetsvariable group import from:eng/pipelines/common-variables.ymlThis is part of the tracked VG20 cleanup: https://dev.azure.com/dnceng/internal/_workitems/edit/12131