Fix build break in AzureBicepResourceScopeTests - #19148
Merged
Adam Ratzman (adamint) merged 1 commit intoAug 7, 2026
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19148Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19148" |
github-actions
Bot
added
the
area-integrations
Contributor
There was a problem hiding this comment.
Pull request overview
Updates stale test call sites after Azure Bicep scope factories were renamed, restoring the Azure test project build.
Changes:
- Uses
CreateForSubscription. - Uses
CreateForTenant.
Show a summary per file
| File | Description |
|---|---|
tests/Aspire.Hosting.Azure.Tests/AzureBicepResourceScopeTests.cs |
Updates tests to use the current factory names. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Sébastien Ros (sebastienros)
approved these changes
Aug 7, 2026
PR microsoft#19084 added AzureBicepResourceScopeTests using the then-current ForSubscription and ForTenant factories. PR microsoft#18976 merged 27 seconds later and renamed the public factories to CreateForSubscription and CreateForTenant after API review. Neither PR conflicted textually on its own branch, but their combination left the new test calling names that no longer exist on main. Update the test to follow the shipping API shape from microsoft#18976 rather than reintroducing the old factory names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adam Ratzman (adamint)
force-pushed
the
adamint/fix-azure-scope-test-build
branch
from
August 7, 2026 19:00
18acd21 to
2d0da86
Compare
Adam Ratzman (adamint)
changed the title
Adam Ratzman (adamint)
changed the title
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mainhas not compiled since 2026-08-07T17:08Z inAspire.Hosting.Azure.Tests.sebastienrosmerged at 17:07:49Z and addedAzureBicepResourceScopeTests.cscallingForSubscription/ForTenant.sebastienrosmerged at 17:08:16Z, 27 seconds later, and renamed those factories toCreateForSubscription/CreateForTenant.Neither PR conflicted textually and each was green against the
mainit branched from, so CI could not catch this semantic merge conflict. This updates the two test call sites to the current API. No product code changes.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?