Repository navigation
Fix Always Encrypted GUID test in multi-server pipelines - #3069
Merged
Merged
Conversation
Reuse the table-creating AE connection and disable decryption only on the ciphertext verification statement. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Muskan Gupta (muskan124947)
October 8, 2026 08:51
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only change correctly uses the statement-level encryption override without altering connection ownership or driver behavior.
0 open findings
What changed in this PR
Fixes the Always Encrypted GUID integration test to verify ciphertext on the same server connection that created the table.
Changes:
- Reuses the AE connection for ciphertext verification.
- Disables column decryption only on the verification statement.
| File | Description |
|---|---|
BulkCopyGuidAETest.java |
Prevents cross-server table lookup failures while preserving ciphertext validation. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Muskan Gupta (muskan124947)
requested review from
Ananya Garg (Ananya2),
Divang Sharma (divang) and
Mahendra Chavan (machavan)
October 8, 2026 09:19
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3069 +/- ##
============================================
+ Coverage 61.51% 61.77% +0.26%
- Complexity 5309 5393 +84
============================================
Files 154 154
Lines 36869 36869
Branches 6789 6789
============================================
+ Hits 22680 22777 +97
+ Misses 10308 10300 -8
+ Partials 3881 3792 -89 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Mahendra Chavan (machavan)
approved these changes
Oct 9, 2026
Divang Sharma (divang)
approved these changes
Oct 9, 2026
Ananya Garg (Ananya2)
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the Always Encrypted GUID bulk-copy test introduced in #3041. The test creates its table through the AE connection, but its ciphertext check opened the base connection, which can target a different server in multi-server configurations and fail with "Invalid object name".
Reuse the connection that created the table and set
SQLServerStatementColumnEncryptionSetting.DISABLEDonly on the ciphertext verification statement. This preserves the AE endpoint and authentication without changing connection-level encryption or enclave settings. The helper closes only its statement and result set; the caller retains ownership of the connection.Test-only change; no driver behavior or public API changes.
Issues
Related to #3041.
Testing
BulkCopyGuidAETest.testBulkCopyGuidIntoEncryptedColumn; retains both decrypted GUID round-trip and ciphertext-length assertions.BulkCopyGuidParserTestandBulkCopyGuidMetadataTest: 44 tests passed under each of thejre11andjre8Maven profiles on JDK 21.git diff --checkpassed.JavaKeyStore.txtis missing. The multi-server AE pipeline must confirm the fix; no local AE pass is claimed.