-
Notifications
You must be signed in to change notification settings - Fork 17
Add Met Office Global Deterministic height level dataset #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks @mo-jeff! Some thoughts:
Let us handle the |
|
@ghidalgo3 - updated this PR. To your comments:
@gadomski - most of the technical detail is here now I think. Descriptions to follow soon. |
@microsoft-github-policy-service agree company="Met Office" |
gadomski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a quick once-over, no major issues. We'll want to populate the item_assets with more information once that's prepared ... I'm working on that now.
datasets/met-office/collection/met-office-global-deterministic-height-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-global-deterministic-height-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-uk-deterministic-height/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-global-deterministic-height/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-uk-deterministic-pressure-level/template.json
Outdated
Show resolved
Hide resolved
…-height-level/template.json Co-authored-by: Pete Gadomski <[email protected]>
…ght-level/template.json Co-authored-by: Pete Gadomski <[email protected]>
datasets/met-office/collection/met-office-global-deterministic-height-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-uk-deterministic-near-surface-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-uk-deterministic-near-surface-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-uk-deterministic-near-surface-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-uk-deterministic-near-surface-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-uk-deterministic-near-surface-level/template.json
Outdated
Show resolved
Hide resolved
…r-surface-level/template.json Co-authored-by: Pete Gadomski <[email protected]>
…r-surface-level/template.json Co-authored-by: Pete Gadomski <[email protected]>
…etary-computer-tasks into met-office-datasets
datasets/met-office/collection/met-office-uk-deterministic-whole-atmosphere/description.md
Show resolved
Hide resolved
...sets/met-office/collection/met-office-uk-deterministic-whole-atmosphere-level/description.md
Outdated
Show resolved
Hide resolved
gadomski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not convinced on the value or correctness of putting 1H_timesteps in cube:dimensions. Any reason not to just keep it in the text descriptions?
I thought Temporal Dimensions might help us with this but maybe not. Happy to keep the Timestep header and content in the collection description and call out in the description for any parameters that don't follow that pattern? For example, there is a precip accumulation that is hourly from T+0 - T+51 (rather than T+54) |
Yeah, the datacube extension is intended to describe a single file. Since your forecast horizons are split into their own standalone files, it's not a good fit for the forecast horizons IMO. Still a good fit for the other dimensions. I think a good text description will be super-helpful for users, so 👍🏼 |
|
@mo-jeff just a heads up that I'm going to be adding a few commits on top of your branch to add ingestion code, etc. I'll try my best to not stomp on any of your changes, but letting you know so you aren't surprised if new commits appear and you need to sync your branch before comitting. |
|
@mo-jeff I've renamed each folder to match the collection id (removed the |
|
@mo-jeff updated the |

Description
Adding content for 8 collections. Things to note:
item_assetsis a static list based on the collection themesType of change
Please delete options that are not relevant.
How Has This Been Tested?
n/a
Checklist:
Please delete options that are not relevant.