Add support for HSQLDB store #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milderhc
reviewed
Sep 24, 2024
...microsoft/semantickernel/data/vectorstorage/attributes/VectorStoreRecordVectorAttribute.java
Outdated
Show resolved
Hide resolved
milderhc
reviewed
Sep 24, 2024
.../src/main/java/com/microsoft/semantickernel/data/vectorstorage/options/GetRecordOptions.java
Show resolved
Hide resolved
milderhc
reviewed
Sep 24, 2024
...microsoft/semantickernel/data/vectorstorage/attributes/VectorStoreRecordVectorAttribute.java
Outdated
Show resolved
Hide resolved
johnoliver
force-pushed
the
hsqldb-2
branch
from
38477a5 to
0ea7ad6
Compare
milderhc
reviewed
Sep 25, 2024
...ava/com/microsoft/semantickernel/samples/syntaxexamples/memory/AzureAISearchVectorStore.java
Show resolved
Hide resolved
milderhc
reviewed
Sep 25, 2024
...java/com/microsoft/semantickernel/connectors/data/hsqldb/HSQLDBVectorStoreQueryProvider.java
Show resolved
Hide resolved
milderhc
reviewed
Sep 25, 2024
...crosoft/semantickernel/tests/connectors/memory/jdbc/JDBCVectorStoreRecordCollectionTest.java
Show resolved
Hide resolved
johnoliver
force-pushed
the
hsqldb-2
branch
from
0ea7ad6 to
3eea6cd
Compare
milderhc
previously approved these changes
Sep 25, 2024
Contributor
milderhc
left a comment
milderhc
left a comment
There was a problem hiding this comment.
LGTM. HSQLDB only needs to be added to JDBCVectorStoreTest
milderhc
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist