Fixes xbox controller crashing the Terminal#20234
Open
phil-scott-78 wants to merge 1 commit into
Open
Conversation
DHowett
reviewed
May 15, 2026
DHowett
left a comment
DHowett
left a comment
Member
There was a problem hiding this comment.
Holy sh-t, thank you!
Can you add the word "BODGY" in all caps to the comment somewhere? Look about the codebase - we use it everywhere XAML has ruined our day :)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
phil-scott-78
force-pushed
the
dev/phils/fix-gamepad-tabview-crash
branch
from
d61a3d7 to
1e8b1aa
Compare
Author
|
BODGY added. I am hesitant to listen to the robots on their spelling suggestions though |
This comment has been minimized.
This comment has been minimized.
Member
|
Nah, check-spelling has historically been very good to us. |
…abView::OnListViewGettingFocus. Add a GettingFocus handler on the TabViewItem that cancels that gamepad focus move before it reaches the framework handler.
phil-scott-78
force-pushed
the
dev/phils/fix-gamepad-tabview-crash
branch
from
1e8b1aa to
5f6a14e
Compare
Author
|
ha, fair enough. Got those tweaks made and it looks like the robots are at peace. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes a denial of service by a toddler with an Xbox controller wanting to play Forza. They can impatiently press up and down and close out the terminal window.
Issue is upstream in WinUI, but I think this gathers things into a state where Terminal can at least recover by adding a
GettingFocushandler on theTabViewItemthat cancels that gamepad focus move before it reaches the framework handler.References and Relevant Issues
Issue #19671 and #20089
Validation Steps Performed
Handed a controller to my toddler while working in terminal. I also banged on the keys myself.
PR Checklist