Disable progress on non-capable terminals #7248
Merged
+28
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On every repo I migrated to MTP, I have always added
--no-progressin CI. This PR makes that a default behavior. When not using a terminal that is capable of writing the progress in place, we don't write progress altogether. IMO, it's never useful to keep writing progress every 3 seconds and always results in a messy output. We will need to also make a similar change to dotnet/sdk.Related to #7056 and other similar issues (not closing any until work is done for dotnet test).