-
Notifications
You must be signed in to change notification settings - Fork 325
Add query parameter list serialization test for CSV format #9231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: lmazuel <[email protected]>
lmazuel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| @doc("List query parameter verification") | ||
| @route("/list") | ||
| interface List { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename it QueryList ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Can you rename it QueryList ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to QueryList in commit 0290e86.
Co-authored-by: lmazuel <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
commit: |
|
@copilot you need to update the ChangeLog of the http-specs package for the CI to pass |
Co-authored-by: lmazuel <[email protected]>
Plan: Add query parameter as list parameter test
/packages/http-specs/specs/parameters/query/main.tsp/packages/http-specs/specs/parameters/query/mockapi.tsListtoQueryListImplementation Summary
Successfully added a new test scenario
Parameters_Query_QueryList_postfor query parameters with list/array values:Changes Made:
QueryListinterface with a POST operation that acceptslistParameter: string[]as a query parameter"a,b,c")Test Details:
POST /parameters/query/listlistParameter(type:string[])["a", "b", "c"]and it should be serialized as"a,b,c"(CSV format)204 No ContentValidation Results:
✅ Scenario validation: PASSED
✅ Mock API validation: PASSED
✅ Code formatting: PASSED
PR Feedback Addressed:
ListtoQueryListas requestedParameters_Query_QueryList_postto matchOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.