Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 22, 2025

fix #9030

In contrast to a single-service client, the root client provided by TCGC has an empty apiVersions list. Since an empty apiVersions list affects versioning validation and the client-level API version signature, this PR introduces two primary changes:

  • It omits setting the client-level signature for multi-service clients because there is no longer a consolidated API version.
  • It adds rootClientApiVersions to certain functions to enable accurate calculation of the addedOn value, which is used for versioning validation.

Copilot AI and others added 2 commits December 22, 2025 06:31
- Update @azure-tools/azure-http-specs from 0.1.0-alpha.34-dev.7 to 0.1.0-alpha.34
- Update @typespec/http-specs from 0.1.0-alpha.30-dev.1 to 0.1.0-alpha.29
- Update @azure-tools/typespec-client-generator-core from ~0.63.0 to ~0.63.1
- Add service/multi-service to regenerate.ts configuration
- Generate Python code for multi-service scenario
- Add test_service_multi_service.py for sync tests
- Add test_service_multi_service_async.py for async tests
- Add changelog entry

Co-authored-by: msyyc <[email protected]>
Copilot AI changed the title [WIP] Update http-client-python dependencies and add tests Update http-client-python dependencies and add multi-service scenario tests Dec 22, 2025
Copilot AI requested a review from msyyc December 22, 2025 06:38
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http@9257
npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client@9257

commit: 0a3f606

@msyyc msyyc changed the title Update http-client-python dependencies and add multi-service scenario tests [python] support multi-service scenario Dec 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

All changed packages have been documented.

  • @typespec/http-client-python
Show changes

@typespec/http-client-python - feature ✏️

Support multi-service scenario.

@msyyc msyyc force-pushed the copilot/update-http-client-dependencies branch from f4188e1 to 76e39ec Compare December 23, 2025 05:12
@msyyc msyyc marked this pull request as ready for review December 24, 2025 02:21
Copy link
Member

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to consider root client's API version in operation group? Can we always rely on operation group level's API version?

@msyyc msyyc requested a review from tadelesh December 24, 2025 08:53
@msyyc
Copy link
Contributor

msyyc commented Dec 24, 2025

Why we need to consider root client's API version in operation group? Can we always rely on operation group level's API version?

After offline discussion with @tadelesh , I replace rootClientApiVersions with serviceApiVersions which is more intuitive. If TCGC could provide the apiVersions info at service level for each type, we could remove the logic related with serviceApiVersions.

@msyyc msyyc added this pull request to the merge queue Dec 25, 2025
Merged via the queue into main with commit c0f4647 Dec 25, 2025
34 checks passed
@msyyc msyyc deleted the copilot/update-http-client-dependencies branch December 25, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

http-client-python Multiples services for one client Implementation

3 participants