Skip to content

Add default for unsafe_allow_symlinks#1601

Open
justinfrevert wants to merge 5 commits into
release/node-1.0.1from
fix-unsafe_allow_symlinks-default
Open

Add default for unsafe_allow_symlinks#1601
justinfrevert wants to merge 5 commits into
release/node-1.0.1from
fix-unsafe_allow_symlinks-default

Conversation

@justinfrevert
Copy link
Copy Markdown
Contributor

@justinfrevert justinfrevert commented May 27, 2026

Overview

Resolves #1599 for nodes who do not use .toml files alongside regular binaries.

Can push this to a new 1.0.1 rc if we'd prefer that to a new rc.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • All commits are signed off (git commit -s) for the DCO
  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
@justinfrevert justinfrevert requested a review from a team as a code owner May 27, 2026 18:29
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Klapeyron
Klapeyron previously approved these changes May 28, 2026
gilescope
gilescope previously approved these changes May 28, 2026
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
@justinfrevert justinfrevert dismissed stale reviews from gilescope and Klapeyron via c145f67 May 28, 2026 13:44
@justinfrevert justinfrevert changed the base branch from release/node-1.0.0 to release/node-1.0.1 May 28, 2026 13:46
gilescope
gilescope previously approved these changes May 28, 2026
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74699ed32b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/tests/docs_tests.rs
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants