This repository was archived by the owner on Aug 18, 2023. It is now read-only.
Implemented Whats New view from Settings#168
Closed
SuzGupta wants to merge 1 commit into
Closed
Conversation
mikaelacaron
suggested changes
Oct 30, 2022
Owner
mikaelacaron
left a comment
mikaelacaron
left a comment
There was a problem hiding this comment.
Hey @SuzGupta Can you make these changes? Thanks! If you can't by the end of Hacktoberfest, that's okay, let me know, and I can make this as hacktoberfest-accepted
I'd be interested instead of hard coding this, directly into the WhatsNewView
Comment on lines
+45
to
+47
| HStack { | ||
| Text("What's New") | ||
| } |
Owner
There was a problem hiding this comment.
This doesn't need to be in an HStack
Comment on lines
+10
to
+23
| struct WhatsNewView: View { | ||
| var body: some View { | ||
| VStack(alignment: .leading, spacing: 10) { | ||
| Text("**v1.2**") | ||
| .font(.title3) | ||
| Text("* Delightful updates arriving soon!") | ||
| Text("**v1.1**") | ||
| .font(.title3) | ||
| Text("* Fix add folder and add tweet button not working in iOS 15") | ||
| } | ||
| .padding() | ||
| Spacer() | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Instead, I was looking for you to create a .md, markdown file, and read from that in this view, rather than hard code the changes into the View itself
Also I'd recommend putting it into a ScrollView to accommodate larger dynamic type sizes
Owner
|
Closing in place of #172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #163
What it Does
How I Tested
Notes
AWSTweet+Extension.swiftwas to resolve a SwiftLint trailing whitespace warning.Screenshot
WhatsNewViewScreenRecording.mp4