Skip to content

Fix build on loongarch64#442

Open
wezm wants to merge 1 commit into
mike-engel:mainfrom
wezm:loongarch
Open

Fix build on loongarch64#442
wezm wants to merge 1 commit into
mike-engel:mainfrom
wezm:loongarch

Conversation

@wezm

@wezm wezm commented Jan 28, 2026

Copy link
Copy Markdown

Summary

Fixes compilation on loongarch64. The previous version of libc in the lock file is missing definitions for loongarch64 architecture. This PR bumps libc to a compatible version.

Preflight checklist

  • Code formatted rustfmt ($ cargo fmt) (code unchanged)
  • Code linter check with clippy ($ cargo clippy) (code unchanged)
  • Relevant tests added (code unchanged)
  • Any new documentation added

@mike-engel

Copy link
Copy Markdown
Owner

@wezm thanks for the PR! Are we able to make this change in the cargo.toml file? I'm not a fan of changing lockfiles directly, as they can change at any point during another install

@wezm

wezm commented Feb 24, 2026

Copy link
Copy Markdown
Author

You could add an explicit dependency libc = "0.2.180" to the Cargo.toml. It would be slightly weird as it wouldn't be used by your project directly, but should have a similar effect. I can do that if you like.

@mike-engel

Copy link
Copy Markdown
Owner

Yeah, I'm worried a future dependency update will change the version of libc in the lockfile, causing issues again. If we're going to say that a specific version of libc is required, then we should state that in the toml file

@wezm

wezm commented Feb 25, 2026

Copy link
Copy Markdown
Author

I'd be surprised if the version in the lockfile went backwards to an incompatible version, but I'll update the PR when I get a moment to include a base version in the Cargo.toml.

Fixes compilation on loongarch64
@wezm

wezm commented Feb 26, 2026

Copy link
Copy Markdown
Author

Righto, I've pushed an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants