Missing record on creating new in find_entry. Fix for access logic #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access logic was flawed because if a name existed that was not banned, the IP was not checked for a ban.
SmallJoker
requested changes
Nov 2, 2025
SmallJoker
reviewed
Nov 7, 2025
SmallJoker
reviewed
Nov 7, 2025
SmallJoker
approved these changes
Nov 13, 2025
Member
SmallJoker
left a comment
SmallJoker
left a comment
There was a problem hiding this comment.
Looks good. will merge in a few days unless there are objections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access logic was flawed because if a name existed that was not banned, the IP was not checked for a ban.
I forgot to add the records table when creating a new entry.(Fix)