Skip to content

aug7 parsing#435

Merged
craffel merged 1 commit intomainfrom
aug7
Feb 19, 2026
Merged

aug7 parsing#435
craffel merged 1 commit intomainfrom
aug7

Conversation

@bmcfee
Copy link
Copy Markdown
Collaborator

@bmcfee bmcfee commented Feb 19, 2026

Fixes #429

This basically consists of adding one more quality decoding map and a corresponding test to ensure that aug7 is parsed correctly.

I don't think there's much else to do here.

@bmcfee bmcfee added this to the 0.9.0 milestone Feb 19, 2026
@bmcfee bmcfee added the bug label Feb 19, 2026
@bmcfee bmcfee requested a review from Copilot February 19, 2026 20:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the aug7 (augmented seventh) chord quality to the chord parsing functionality. The issue occurred because aug7 was already recognized by the regex pattern for valid chord labels but was missing from the QUALITIES dictionary, causing encoding failures.

Changes:

  • Added aug7 chord quality bitmap definition to QUALITIES dictionary in mir_eval/chord.py
  • Added test case for Ab:aug7 chord encoding in tests/test_chord.py

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
mir_eval/chord.py Added aug7 quality bitmap [1,0,0,0,1,0,0,0,1,0,1,0] representing root, major 3rd, augmented 5th, and minor 7th
tests/test_chord.py Added test case verifying Ab:aug7 encodes correctly with expected root, interval bitmap, and bass values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 85.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mir_eval/chord.py 99.20% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@craffel
Copy link
Copy Markdown
Collaborator

craffel commented Feb 19, 2026

Looks ok to merge too?

@bmcfee
Copy link
Copy Markdown
Collaborator Author

bmcfee commented Feb 19, 2026

:shipit:

@craffel craffel merged commit fe73b35 into main Feb 19, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aug7 chord cannot be encoded

3 participants