Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the aug7 (augmented seventh) chord quality to the chord parsing functionality. The issue occurred because aug7 was already recognized by the regex pattern for valid chord labels but was missing from the QUALITIES dictionary, causing encoding failures.
Changes:
- Added
aug7chord quality bitmap definition to QUALITIES dictionary in mir_eval/chord.py - Added test case for
Ab:aug7chord encoding in tests/test_chord.py
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mir_eval/chord.py | Added aug7 quality bitmap [1,0,0,0,1,0,0,0,1,0,1,0] representing root, major 3rd, augmented 5th, and minor 7th |
| tests/test_chord.py | Added test case verifying Ab:aug7 encodes correctly with expected root, interval bitmap, and bass values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
|
Looks ok to merge too? |
Collaborator
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #429
This basically consists of adding one more quality decoding map and a corresponding test to ensure that aug7 is parsed correctly.
I don't think there's much else to do here.