Repository navigation
Conversation
The gateway job configures chronos-core through add_subdirectory, and its CMakeLists.txt requires the pybind11 CMake package. The job did not install pybind11, so configure stopped at find_package(pybind11) on every run. Install pybind11-dev with the other build dependencies, as docs/installation.md does for the gateway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gatewayjob in relational-package.yml has failed on every push to main since it was added in e386c79 (for example, run 37950753911). It configurespackages/chronos-gateway, which pulls in chronos-core throughadd_subdirectory, and chronos-core's CMakeLists.txt#L11 callsfind_package(pybind11 CONFIG REQUIRED). The job doesn't install pybind11, so configure stops withCould not find a package configuration file provided by "pybind11".This adds
pybind11-devto the job's apt list, which is the package docs/installation.md already lists for building the gateway. Ubuntu 22.04 ships 2.9.1, which is older than the 2.12 the wheel build asks for, but the gateway doesn't build the Python module and compiles fine with it. If you'd rather match the wheel's version, I can install pybind11 from pip and pass its CMake dir as-Dpybind11_DIRinstead. I tried that too (with 3.1), and it also builds and passes ctest.Tests