Skip to content

OS Command Injection in cmd_tuner_scan_channels_save #75

Description

@lnnew

The server code uses system() to create directories using unsanitized paths derived from configuration or environment variables.

// libdvbtee_server/serve.cpp ~line 1195
char cmd_buf[32] = { 0 };
// 'dir' is unsanitized. If dir contains "; rm -rf /", it executes.
sprintf(cmd_buf, "mkdir -p %s", dir);
if (system(cmd_buf) < 0) { ... }

This allows command injection if the HOME environment variable or channels.conf is modified.

Consider fixing: Avoid system(). Use the native mkdir() syscall instead.

#include <sys/stat.h>
// ...
mkdir(dir, 0755);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions