Expose mlx_fast_rope_offset_array #305
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add array offset support to
MLXFast.RoPEto match the Python MLX API.Dependencies
Motivation
The Python
mlx.core.fast.ropefunction acceptsoffsetas either an int or array.This enables several important use cases:
Changes
MLXFast.RoPE(..., offset: MLXArray, ...)overloadMLXNN.RoPE.callAsFunction(_:offset:)overloadExample
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes